Commit Graph

2184 Commits

Author SHA1 Message Date
schroda
c2c4115c9c Reset reader settings state on exit 2024-12-31 14:52:50 +01:00
schroda
7f04f1c860 Consider unset reader chapter as still loading
In case the "currentChapter" is undefined, it means that the state has not been set yet.
In case the "currentChapter" does not exist, it would be set to "null".
2024-12-31 14:52:49 +01:00
schroda
83e8a5fec1 Correctly check if reader chapter exists
As explained in c70287363a8e9308fc294baf83c5656a21a479b1, the "chapterSourceOrder" does not start at 0, thus, in case it's the last known chapter, "doesChapterExist" was always false due to subtracting 1 of the total chapters
2024-12-31 14:52:48 +01:00
schroda
899364ac85 Use proper name for reader url chapter "index" param
It's not the index of the chapter but the source order, which is starting at 1 and not 0
2024-12-31 14:52:47 +01:00
schroda
17cf8ec9d0 Update "pagesToSpreadState" during render
Gets rid of an unnecessary rendering
2024-12-31 13:25:37 +01:00
schroda
3bab657c52 Update "actualPages" immediately
Instead of immediately updating the value once the page count changed, it got updated after "pagesToSpreadState" changed, which was after the rendering finished.

This was the actual root cause of what was tried to be fixed with 9ab6ec89c7
2024-12-31 13:24:29 +01:00
schroda
36ae02d2bd Revert "Fix page resume in continuous pagers"
This reverts commit 9ab6ec89c7.
2024-12-31 12:46:25 +01:00
schroda
8594a7b178 Increase reserved "current page" text for double pager
For the double pager the current page text needs more reserved space since two pages are displayed at once which changes the current page text to "<page1>-<page2>" instead of just "<page1>"
2024-12-31 04:38:11 +01:00
schroda
a0df80f60a Fix opening previous/next page via user action
Regression 55dc9471d9
2024-12-31 04:24:47 +01:00
schroda
9ab6ec89c7 Fix page resume in continuous pagers
The image refs weren't always set by the time the last read page got resumed.
Thus, the last read page never got scrolled into view
2024-12-31 04:05:53 +01:00
schroda
f808614e6c Prevent layout shifts in continuous pagers
I was unable to find a fix for this problem, thus, the only solution I see is disabling this functionality for the continuous readers.

Due to preloading leading pages, the layout got shifted once the pages got loaded.
This messed with the scroll position which caused the top of the scrolled into views pages to not be at the top of the viewport anymore.
2024-12-31 02:51:20 +01:00
schroda
1d955257dd Prevent page jump on scroll to page
When an unloaded page got scrolled into view, the current page got incorrectly set to the next page once the page got loaded
2024-12-31 02:46:07 +01:00
schroda
d885b4904e Render pages only once reader settings have been set
For the reader to be ready it's necessary that the settings not only have been loaded but also that the settings context is properly set
2024-12-31 02:46:04 +01:00
schroda
283bc1f706 Wait till reader setting are set to show previews
Sometimes the reader settings state took too long to get set and the previews were shown using the default settings first, since they are set as the default values of the reader settings context, and then again for the final settings
2024-12-31 02:45:12 +01:00
schroda
14044af1cd Reset "transition page mode" on reader exit 2024-12-31 02:21:36 +01:00
schroda
740acf63fc Show default "reading mode" setting
Regression 6ca6864035
2024-12-31 01:08:13 +01:00
schroda
9b706d0c82 Delay "reading mode" and "tap zone" preview until reader is ready 2024-12-30 21:23:39 +01:00
schroda
f8d3be3911 Do not check for state change before set state call
Due to not including the states in the dependency array (to improve render performance), they do not include updated data and might cause an incorrect early exit.

E.g. in case a load error happened for a page whose loaded flag was already set to true, the pages load state never got updated again
2024-12-30 21:21:09 +01:00
schroda
95f95e770f Prevent TypeError and incorrect state updates for "pagesSpreadState"
Page spread state updates of an already closed chapter caused TypeErrors or incorrect state updates.
2024-12-30 21:03:13 +01:00
schroda
7c98bab43b Prevent TypeError and incorrect state updates for "pageLoadStates"
Page load state updates of an already closed chapter caused TypeErrors or incorrect state updates.
2024-12-30 21:03:10 +01:00
schroda
55dc9471d9 Hide chapter transition page in single/double pagers
Transition page got opened and never closed again due to not correctly detecting that a transition page is currently visible
2024-12-30 19:57:18 +01:00
schroda
1f3a3b6c39 Auto hide "tap zone layout" preview when opening reader 2024-12-30 19:41:49 +01:00
schroda
fa868ea222 Properly detect "reading mode" and "tap zone" changes for preview 2024-12-30 19:33:37 +01:00
schroda
45f46a05d0 Optionally show preview or "reading mode" and "tap zone overlay"
Shows a preview when opening the reader or when the values change
2024-12-30 16:51:39 +01:00
schroda
f3962646e6 Hide "tap zone overlay" on user action 2024-12-30 16:50:54 +01:00
schroda
6a32395234 Always show "tap zone layout" preview when necessary
In case the "tap zone layout" setting value got changed from or to the same value as the default value, the preview was never shown due to the canvas being reused and therefore not triggering the useEffect
2024-12-30 16:32:30 +01:00
schroda
6ca6864035 Make active reading mode default settings editable in reader 2024-12-30 14:52:09 +01:00
schroda
6bf3e297ef Open previous/next chapter at end of continuous pager via hotkey
For continuous pagers the chapter transition page is always visible regardless of the current "transitionPageMode".
However, this was not properly checked and thus, it wasn't considered to be visible and instead of opening the previous/next chapter, the transition page got set to be visible first and only with the second hotkey press did the chapter get opened
2024-12-30 14:12:11 +01:00
schroda
4fc4a8d9b3 Move library display options to global metadata
- showContinueReadingButton
- showDownloadBadge
- showUnreadBadge
2024-12-30 03:49:39 +01:00
schroda
8dc5ec339c Decrease "MIN_SCROLL_AMOUNT_PX" to 1px
Got removed from 00170c8e4a due to rebasing and squashing...
2024-12-30 02:19:17 +01:00
schroda
00170c8e4a Properly calculate auto scroll px amount
"scrollBy" and "scrollTo" require a change of at least 1px, otherwise, nothing will happen
2024-12-30 02:13:57 +01:00
schroda
ce49084a89 Auto open next page after first change in single/double pager 2024-12-30 02:13:57 +01:00
schroda
e2dd5ad211 Use animation frames for auto scrolling continuous pagers 2024-12-30 02:13:56 +01:00
schroda
8eae025d8f Use "coerceIn" util function 2024-12-29 23:41:27 +01:00
schroda
530ae1578f Prevent invalid values for "auto scroll speed"
The min/max limit was only acknowledged when the value was changed via MUIs step logic.
In case the number got inputted via keystrokes the limits did not get applied
2024-12-29 23:41:26 +01:00
schroda
06d0f7147a Update auto scroll direction on reader reading direction change 2024-12-29 23:41:25 +01:00
schroda
d90767c71c Add "increase/decrease auto scroll speed" hotkeys 2024-12-29 23:41:24 +01:00
schroda
3238103ca0 Fix "rtl" detection in "useMouseDragScroll"
"isRTL" was set to the direction value instead of correctly to the boolean flag indicating if it is the actual rtl direction value.

This didn't cause any issues because for ltr because for ltr the result of "scrollAtT0.current[X] - delta[X])" was never less than "-maxScrollPos[X]" and for rtl it always used the expected value since "isRTL" was truthy.
2024-12-29 22:14:44 +01:00
schroda
e459e94b71 Properly invert scroll direction in "useAutomaticScrolling" 2024-12-29 22:04:46 +01:00
schroda
732f27f319 Fix "rtl" detection in "useAutomaticScrolling" 2024-12-29 22:04:21 +01:00
schroda
74d9e21c76 Abort auto scroll interval for callback mode 2024-12-29 21:42:00 +01:00
schroda
a943d2f2bc Extract logic from "ReaderViewer" into functions and hooks 2024-12-29 21:38:31 +01:00
schroda
9438a2f626 Unmount "ReaderNavBarDesktop" on exit
Re-rendering the component isn't too expensive and unmounting it improves the re-rendering caused by page changes since it doesn't get updated.

This removes ~7ms on a "current page" state update and ~25ms caused by the chapter update due to the "last read page" change
2024-12-29 21:38:31 +01:00
schroda
94ee7d4958 Improve "page spread page state" updates
Since "pagesToSpreadState" isn't part of the dependency array and also would decrease the render performance if it was (see reasoning of c79f7cc874), the array reference might be out of date and thus, the guard might not work correctly
2024-12-29 21:38:24 +01:00
schroda
c79f7cc874 Improve "page load state" updates
Changes of d6ff85fdd3 decreased the render performance due to the "onLoad" function changing and causing all pages to re-render.
2024-12-29 17:21:37 +01:00
schroda
aee42d7bb1 Adjust "MobileReaderProgressBar" active dragging styling 2024-12-28 04:06:03 +01:00
schroda
3185449816 Improve "MobileReaderProgressBar" progress bar click/drag handling
Convert clicks on the progress bar in such a way, that there is a "padding" around the page "dots".
Thus, e.g. even if the click was actually for page 1, if it is inside page 2 padding, it will behave like it was a click for page 2
2024-12-28 04:05:29 +01:00
schroda
bc14b68507 Cleanup progress bar interaction handling 2024-12-28 02:33:33 +01:00
schroda
6bae3aaf3a Improve progress bar dragging detection 2024-12-28 02:33:06 +01:00
schroda
0c6872edb3 Improve progress bar rendering while dragging 2024-12-28 02:00:13 +01:00