ChoChoX/suwayomi-material-you-webui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix/setting buttons unclickable area (#379)

Browse Source 
* Move "onClick" handler to "ListItemButton" - LibrarySettings "global update categories"

Clicks were only handled on the button content leading to a small area around the content to not handle the clicks, thus, not opening the dialog

* Move "onClick" handler to "ListItemButton" - Settings "manga item width"

Clicks were only handled on the button content leading to a small area around the content to not handle the clicks, thus, not opening the dialog
This commit is contained in:
schroda
2023-06-20 00:58:40 +02:00
committed by GitHub
parent 0f029cb625
commit 79b5e696b6
2 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/screens/Settings.tsx
View File

@@ -139,17 +139,15 @@ export default function Settings() {
</ListItemSecondaryAction>
</ListItem>
<SearchSettings />
<ListItemButton>
<ListItemButton
onClick={() => {
handleDialogOpenItemWidth();
}}
>
<ListItemIcon>
<ViewModuleIcon />
</ListItemIcon>
<ListItemText
primary={t('settings.label.manga_item_width')}
secondary={`px:${ItemWidth}`}
onClick={() => {
handleDialogOpenItemWidth();
}}
/>
<ListItemText primary={t('settings.label.manga_item_width')} secondary={`px:${ItemWidth}`} />
</ListItemButton>
<ListItem>
<ListItemIcon>

3
src/screens/settings/LibrarySettings.tsx
View File

@@ -145,7 +145,7 @@ export default function LibrarySettings() {
</ListSubheader>
}
>
<ListItemButton>
<ListItemButton onClick={() => setIsDialogOpen(true)}>
<ListItemText
primary={t('category.title.categories')}
secondary={
@@ -163,7 +163,6 @@ export default function LibrarySettings() {
</>
}
secondaryTypographyProps={{ style: { display: 'flex', flexDirection: 'column' } }}
onClick={() => setIsDialogOpen(true)}
/>
</ListItemButton>
</List>