Properly update "StandardReaderProgressBar" slots on "progress bar position" change
"createProgressBarSlot" was never called in case the function reference changed but none of the passed arguments
This commit is contained in:
@@ -73,6 +73,7 @@ export const ReaderProgressBarSlotWrapper = memo(
|
||||
totalPages,
|
||||
),
|
||||
[
|
||||
createProgressBarSlot,
|
||||
page,
|
||||
pagesIndex,
|
||||
primaryPageLoadState,
|
||||
|
||||
@@ -20,28 +20,27 @@ export const ReaderProgressBarSlotDesktop = memo(
|
||||
pageUrl,
|
||||
primaryPageLoadState,
|
||||
secondaryPageLoadState,
|
||||
isHorizontal,
|
||||
isVertical,
|
||||
progressBarPosition,
|
||||
isCurrentPage,
|
||||
isFirstPage,
|
||||
isLastPage,
|
||||
isLeadingPage,
|
||||
isDragging,
|
||||
}: Pick<IReaderSettings, 'progressBarPosition'> &
|
||||
Pick<ReturnType<typeof getProgressBarPositionInfo>, 'isHorizontal' | 'isVertical'> & {
|
||||
pageName: string;
|
||||
pageUrl: string;
|
||||
primaryPageLoadState: boolean;
|
||||
secondaryPageLoadState?: boolean;
|
||||
isCurrentPage: boolean;
|
||||
isFirstPage: boolean;
|
||||
isLastPage: boolean;
|
||||
isLeadingPage: boolean;
|
||||
isDragging: boolean;
|
||||
}) => {
|
||||
}: Pick<IReaderSettings, 'progressBarPosition'> & {
|
||||
pageName: string;
|
||||
pageUrl: string;
|
||||
primaryPageLoadState: boolean;
|
||||
secondaryPageLoadState?: boolean;
|
||||
isCurrentPage: boolean;
|
||||
isFirstPage: boolean;
|
||||
isLastPage: boolean;
|
||||
isLeadingPage: boolean;
|
||||
isDragging: boolean;
|
||||
}) => {
|
||||
const theme = useTheme();
|
||||
|
||||
const { isVertical, isHorizontal } = getProgressBarPositionInfo(progressBarPosition);
|
||||
|
||||
return (
|
||||
<ReaderProgressBarSlot
|
||||
key={pageUrl}
|
||||
|
||||
@@ -71,8 +71,6 @@ const BaseStandardReaderProgressBar = ({
|
||||
pageUrl={page.primary.url}
|
||||
primaryPageLoadState={primaryPageLoadState}
|
||||
secondaryPageLoadState={secondaryPageLoadState}
|
||||
isHorizontal={isHorizontal}
|
||||
isVertical={isVertical}
|
||||
progressBarPosition={progressBarPosition}
|
||||
isCurrentPage={isCurrentPage}
|
||||
isFirstPage={pagesIndex === 0}
|
||||
@@ -81,7 +79,7 @@ const BaseStandardReaderProgressBar = ({
|
||||
isDragging={isDragging}
|
||||
/>
|
||||
),
|
||||
[isHorizontal, isVertical, isDragging, progressBarPosition],
|
||||
[progressBarPosition, isDragging],
|
||||
)}
|
||||
slotProps={{
|
||||
container: {
|
||||
|
||||
Reference in New Issue
Block a user