From 3ca379c0f12227295f5a2f4b1fdd53f29bfcb182 Mon Sep 17 00:00:00 2001
From: schroda <50052685+schroda@users.noreply.github.com>
Date: Fri, 27 Dec 2024 17:16:35 +0100
Subject: [PATCH] Properly update "StandardReaderProgressBar" slots on
 "progress bar position" change

"createProgressBarSlot" was never called in case the function reference changed but none of the passed arguments
---
 .../ReaderProgressBarSlotWrapper.tsx          |  1 +
 .../desktop/ReaderProgressBarSlotDesktop.tsx  | 27 +++++++++----------
 .../variants/StandardReaderProgressBar.tsx    |  4 +--
 3 files changed, 15 insertions(+), 17 deletions(-)

diff --git a/src/modules/reader/components/overlay/progress-bar/ReaderProgressBarSlotWrapper.tsx b/src/modules/reader/components/overlay/progress-bar/ReaderProgressBarSlotWrapper.tsx
index 7cd7e6de..6f84cb57 100644
--- a/src/modules/reader/components/overlay/progress-bar/ReaderProgressBarSlotWrapper.tsx
+++ b/src/modules/reader/components/overlay/progress-bar/ReaderProgressBarSlotWrapper.tsx
@@ -73,6 +73,7 @@ export const ReaderProgressBarSlotWrapper = memo(
                     totalPages,
                 ),
             [
+                createProgressBarSlot,
                 page,
                 pagesIndex,
                 primaryPageLoadState,
diff --git a/src/modules/reader/components/overlay/progress-bar/desktop/ReaderProgressBarSlotDesktop.tsx b/src/modules/reader/components/overlay/progress-bar/desktop/ReaderProgressBarSlotDesktop.tsx
index bad88fa5..59739a95 100644
--- a/src/modules/reader/components/overlay/progress-bar/desktop/ReaderProgressBarSlotDesktop.tsx
+++ b/src/modules/reader/components/overlay/progress-bar/desktop/ReaderProgressBarSlotDesktop.tsx
@@ -20,28 +20,27 @@ export const ReaderProgressBarSlotDesktop = memo(
         pageUrl,
         primaryPageLoadState,
         secondaryPageLoadState,
-        isHorizontal,
-        isVertical,
         progressBarPosition,
         isCurrentPage,
         isFirstPage,
         isLastPage,
         isLeadingPage,
         isDragging,
-    }: Pick<IReaderSettings, 'progressBarPosition'> &
-        Pick<ReturnType<typeof getProgressBarPositionInfo>, 'isHorizontal' | 'isVertical'> & {
-            pageName: string;
-            pageUrl: string;
-            primaryPageLoadState: boolean;
-            secondaryPageLoadState?: boolean;
-            isCurrentPage: boolean;
-            isFirstPage: boolean;
-            isLastPage: boolean;
-            isLeadingPage: boolean;
-            isDragging: boolean;
-        }) => {
+    }: Pick<IReaderSettings, 'progressBarPosition'> & {
+        pageName: string;
+        pageUrl: string;
+        primaryPageLoadState: boolean;
+        secondaryPageLoadState?: boolean;
+        isCurrentPage: boolean;
+        isFirstPage: boolean;
+        isLastPage: boolean;
+        isLeadingPage: boolean;
+        isDragging: boolean;
+    }) => {
         const theme = useTheme();
 
+        const { isVertical, isHorizontal } = getProgressBarPositionInfo(progressBarPosition);
+
         return (
             <ReaderProgressBarSlot
                 key={pageUrl}
diff --git a/src/modules/reader/components/overlay/progress-bar/variants/StandardReaderProgressBar.tsx b/src/modules/reader/components/overlay/progress-bar/variants/StandardReaderProgressBar.tsx
index 96b190f6..bbfb75a4 100644
--- a/src/modules/reader/components/overlay/progress-bar/variants/StandardReaderProgressBar.tsx
+++ b/src/modules/reader/components/overlay/progress-bar/variants/StandardReaderProgressBar.tsx
@@ -71,8 +71,6 @@ const BaseStandardReaderProgressBar = ({
                             pageUrl={page.primary.url}
                             primaryPageLoadState={primaryPageLoadState}
                             secondaryPageLoadState={secondaryPageLoadState}
-                            isHorizontal={isHorizontal}
-                            isVertical={isVertical}
                             progressBarPosition={progressBarPosition}
                             isCurrentPage={isCurrentPage}
                             isFirstPage={pagesIndex === 0}
@@ -81,7 +79,7 @@ const BaseStandardReaderProgressBar = ({
                             isDragging={isDragging}
                         />
                     ),
-                    [isHorizontal, isVertical, isDragging, progressBarPosition],
+                    [progressBarPosition, isDragging],
                 )}
                 slotProps={{
                     container: {