Remove enabling notifyOnNetworkStatusChange usages

Starting with v4 this flag is now enabled by default
This commit is contained in:
schroda
2026-05-02 17:37:38 +02:00
parent 515c402aca
commit 00bba202ef
28 changed files with 26 additions and 70 deletions

View File

@@ -41,7 +41,6 @@ export const ServerUpdateChecker = () => {
error: serverUpdateCheckError, error: serverUpdateCheckError,
refetch: checkForUpdate, refetch: checkForUpdate,
} = requestManager.useCheckForServerUpdate({ } = requestManager.useCheckForServerUpdate({
notifyOnNetworkStatusChange: true,
fetchPolicy: 'cache-only', fetchPolicy: 'cache-only',
}); });

View File

@@ -57,7 +57,6 @@ export const WebUIUpdateChecker = () => {
const { aboutWebUI } = aboutData ?? STABLE_EMPTY_OBJECT; const { aboutWebUI } = aboutData ?? STABLE_EMPTY_OBJECT;
const { data: webUIUpdateData, refetch: checkForUpdate } = requestManager.useCheckForWebUIUpdate({ const { data: webUIUpdateData, refetch: checkForUpdate } = requestManager.useCheckForWebUIUpdate({
notifyOnNetworkStatusChange: true,
fetchPolicy: 'cache-only', fetchPolicy: 'cache-only',
}); });

View File

@@ -53,12 +53,7 @@ export function Backup() {
useAppTitle(t`Backup`); useAppTitle(t`Backup`);
const { const { data: settingsData, loading, error, refetch } = requestManager.useGetServerSettings();
data: settingsData,
loading,
error,
refetch,
} = requestManager.useGetServerSettings({ notifyOnNetworkStatusChange: true });
const [mutateSettings] = requestManager.useUpdateServerSettings(); const [mutateSettings] = requestManager.useUpdateServerSettings();
const { data } = requestManager.useGetBackupRestoreStatus(backupRestoreId ?? '', { const { data } = requestManager.useGetBackupRestoreStatus(backupRestoreId ?? '', {

View File

@@ -121,7 +121,7 @@ export function Extensions({ tabsMenuHeight }: { tabsMenuHeight: number }) {
loading: areServerSettingsLoading, loading: areServerSettingsLoading,
error: serverSettingsError, error: serverSettingsError,
refetch: refetchServerSettings, refetch: refetchServerSettings,
} = requestManager.useGetServerSettings({ notifyOnNetworkStatusChange: true }); } = requestManager.useGetServerSettings();
const [fetchExtensions, { data, loading: areExtensionsLoading, error: extensionsError }] = const [fetchExtensions, { data, loading: areExtensionsLoading, error: extensionsError }] =
requestManager.useExtensionListFetch(); requestManager.useExtensionListFetch();

View File

@@ -36,9 +36,7 @@ export const BrowseSettings = () => {
useAppTitle(t`Browse`); useAppTitle(t`Browse`);
const { data, loading, error, refetch } = requestManager.useGetServerSettings({ const { data, loading, error, refetch } = requestManager.useGetServerSettings();
notifyOnNetworkStatusChange: true,
});
const [mutateSettings] = requestManager.useUpdateServerSettings(); const [mutateSettings] = requestManager.useUpdateServerSettings();
const updateSetting = <Setting extends keyof ExtensionsSettings>( const updateSetting = <Setting extends keyof ExtensionsSettings>(

View File

@@ -40,12 +40,7 @@ export function Sources({ tabsMenuHeight }: { tabsMenuHeight: number }) {
settings: { showNsfw, lastUsedSourceId }, settings: { showNsfw, lastUsedSourceId },
} = useMetadataServerSettings(); } = useMetadataServerSettings();
const { const { data, loading: isLoading, error, refetch } = requestManager.useGetSourceList();
data,
loading: isLoading,
error,
refetch,
} = requestManager.useGetSourceList({ notifyOnNetworkStatusChange: true });
const sources = data?.sources.nodes ?? STABLE_EMPTY_ARRAY; const sources = data?.sources.nodes ?? STABLE_EMPTY_ARRAY;
const filteredSources = useMemo( const filteredSources = useMemo(
() => () =>

View File

@@ -44,7 +44,7 @@ export function CategorySettings() {
const { data, loading, error, refetch } = requestManager.useGetCategories< const { data, loading, error, refetch } = requestManager.useGetCategories<
GetCategoriesSettingsQuery, GetCategoriesSettingsQuery,
GetCategoriesSettingsQueryVariables GetCategoriesSettingsQueryVariables
>(GET_CATEGORIES_SETTINGS, { notifyOnNetworkStatusChange: true }); >(GET_CATEGORIES_SETTINGS);
const [reorderCategory, { reset: revertReorder }] = requestManager.useReorderCategory(); const [reorderCategory, { reset: revertReorder }] = requestManager.useReorderCategory();
const [categoryToEdit, setCategoryToEdit] = useState<number>(CREATE_NEW_CATEGORY_ID); const [categoryToEdit, setCategoryToEdit] = useState<number>(CREATE_NEW_CATEGORY_ID);

View File

@@ -139,7 +139,6 @@ export const ChapterList = ({
} = requestManager.useGetMangaChapters<GetChaptersMangaQuery, GetChaptersMangaQueryVariables>( } = requestManager.useGetMangaChapters<GetChaptersMangaQuery, GetChaptersMangaQueryVariables>(
GET_CHAPTERS_MANGA, GET_CHAPTERS_MANGA,
manga.id, manga.id,
{ notifyOnNetworkStatusChange: true },
); );
const chapters = chaptersData?.chapters.nodes ?? STABLE_EMPTY_ARRAY; const chapters = chaptersData?.chapters.nodes ?? STABLE_EMPTY_ARRAY;

View File

@@ -42,12 +42,7 @@ export const DownloadQueue: React.FC = () => {
const [reorderDownload, { reset: revertReorder }] = requestManager.useReorderChapterInDownloadQueue(); const [reorderDownload, { reset: revertReorder }] = requestManager.useReorderChapterInDownloadQueue();
const { const { data: downloadStatusData, loading: isLoading, error, refetch } = requestManager.useGetDownloadStatus();
data: downloadStatusData,
loading: isLoading,
error,
refetch,
} = requestManager.useGetDownloadStatus({ notifyOnNetworkStatusChange: true });
const downloaderData = downloadStatusData?.downloadStatus; const downloaderData = downloadStatusData?.downloadStatus;
const queue = downloaderData?.queue ?? STABLE_EMPTY_ARRAY; const queue = downloaderData?.queue ?? STABLE_EMPTY_ARRAY;

View File

@@ -58,7 +58,7 @@ export const DownloadSettings = () => {
const categories = requestManager.useGetCategories<GetCategoriesSettingsQuery, GetCategoriesSettingsQueryVariables>( const categories = requestManager.useGetCategories<GetCategoriesSettingsQuery, GetCategoriesSettingsQueryVariables>(
GET_CATEGORIES_SETTINGS, GET_CATEGORIES_SETTINGS,
); );
const serverSettings = requestManager.useGetServerSettings({ notifyOnNetworkStatusChange: true }); const serverSettings = requestManager.useGetServerSettings();
const [mutateSettings] = requestManager.useUpdateServerSettings(); const [mutateSettings] = requestManager.useUpdateServerSettings();
const { const {
settings: metadataSettings, settings: metadataSettings,

View File

@@ -265,7 +265,7 @@ export const SearchAll = ({
settings: { showNsfw, shouldShowOnlySourcesWithResults }, settings: { showNsfw, shouldShowOnlySourcesWithResults },
} = useMetadataServerSettings(); } = useMetadataServerSettings();
const { data, loading, error, refetch } = requestManager.useGetSourceList({ notifyOnNetworkStatusChange: true }); const { data, loading, error, refetch } = requestManager.useGetSourceList();
const tmpSources = data?.sources.nodes ?? STABLE_EMPTY_ARRAY; const tmpSources = data?.sources.nodes ?? STABLE_EMPTY_ARRAY;
const sources = useMemo( const sources = useMemo(
() => () =>

View File

@@ -36,7 +36,6 @@ export const History: React.FC = () => {
refetch, refetch,
} = requestManager.useGetRecentlyReadChapters(undefined, { } = requestManager.useGetRecentlyReadChapters(undefined, {
fetchPolicy: 'cache-and-network', fetchPolicy: 'cache-and-network',
notifyOnNetworkStatusChange: true,
}); });
const hasNextPage = !!chapterHistoryData?.chapters.pageInfo.hasNextPage; const hasNextPage = !!chapterHistoryData?.chapters.pageInfo.hasNextPage;
const endCursor = chapterHistoryData?.chapters.pageInfo.endCursor; const endCursor = chapterHistoryData?.chapters.pageInfo.endCursor;

View File

@@ -76,9 +76,6 @@ export function Library() {
refetch: refetchCategories, refetch: refetchCategories,
} = requestManager.useGetCategories<GetCategoriesLibraryQuery, GetCategoriesLibraryQueryVariables>( } = requestManager.useGetCategories<GetCategoriesLibraryQuery, GetCategoriesLibraryQueryVariables>(
GET_CATEGORIES_LIBRARY, GET_CATEGORIES_LIBRARY,
{
notifyOnNetworkStatusChange: true,
},
); );
const tabsData = categoriesResponse?.categories.nodes.filter( const tabsData = categoriesResponse?.categories.nodes.filter(
(category) => category.id !== 0 || (category.id === 0 && category.mangas.totalCount), (category) => category.id !== 0 || (category.id === 0 && category.mangas.totalCount),
@@ -102,7 +99,7 @@ export function Library() {
error: mangaError, error: mangaError,
loading: mangaLoading, loading: mangaLoading,
refetch: refetchCategoryMangas, refetch: refetchCategoryMangas,
} = requestManager.useGetCategoryMangas(activeTab?.id, { skip: !activeTab, notifyOnNetworkStatusChange: true }); } = requestManager.useGetCategoryMangas(activeTab?.id, { skip: !activeTab });
const categoryMangas = categoryMangaResponse?.mangas.nodes ?? STABLE_EMPTY_ARRAY; const categoryMangas = categoryMangaResponse?.mangas.nodes ?? STABLE_EMPTY_ARRAY;
const { const {
visibleMangas: mangas, visibleMangas: mangas,

View File

@@ -74,7 +74,7 @@ export function LibrarySettings() {
const categories = requestManager.useGetCategories<GetCategoriesSettingsQuery, GetCategoriesSettingsQueryVariables>( const categories = requestManager.useGetCategories<GetCategoriesSettingsQuery, GetCategoriesSettingsQueryVariables>(
GET_CATEGORIES_SETTINGS, GET_CATEGORIES_SETTINGS,
); );
const serverSettings = requestManager.useGetServerSettings({ notifyOnNetworkStatusChange: true }); const serverSettings = requestManager.useGetServerSettings();
const { const {
settings, settings,
loading: areMetadataServerSettingsLoading, loading: areMetadataServerSettingsLoading,

View File

@@ -44,9 +44,7 @@ export const MigrationSelectDestinationSources = () => {
loading: areSourcesLoading, loading: areSourcesLoading,
error: sourceError, error: sourceError,
refetch: refetchSources, refetch: refetchSources,
} = requestManager.useGetSourceList({ } = requestManager.useGetSourceList();
notifyOnNetworkStatusChange: true,
});
const allSources = data?.sources.nodes ?? STABLE_EMPTY_ARRAY; const allSources = data?.sources.nodes ?? STABLE_EMPTY_ARRAY;
const sources = useMemo( const sources = useMemo(

View File

@@ -58,7 +58,7 @@ export const MigrationSelectMangas = () => {
} = requestManager.useGetSource<GetSourceMigratableQuery, GetSourceMigratableQueryVariables>( } = requestManager.useGetSource<GetSourceMigratableQuery, GetSourceMigratableQueryVariables>(
GET_SOURCE_MIGRATABLE, GET_SOURCE_MIGRATABLE,
sourceId ?? '', sourceId ?? '',
{ skip: !sourceIds, notifyOnNetworkStatusChange: true }, { skip: !sourceIds },
); );
const { const {
@@ -68,7 +68,6 @@ export const MigrationSelectMangas = () => {
refetch: refetchMangas, refetch: refetchMangas,
} = requestManager.useGetMigratableSourceMangas(sourceId!, { } = requestManager.useGetMigratableSourceMangas(sourceId!, {
skip: !sourceIds, skip: !sourceIds,
notifyOnNetworkStatusChange: true,
}); });
const mangas = migratableSourceMangasData?.mangas.nodes ?? STABLE_EMPTY_ARRAY; const mangas = migratableSourceMangasData?.mangas.nodes ?? STABLE_EMPTY_ARRAY;

View File

@@ -91,9 +91,7 @@ export const MigrationSelectSource = ({ tabsMenuHeight }: { tabsMenuHeight: numb
); );
const { sortBy, sortOrder } = migrateSortSettings; const { sortBy, sortOrder } = migrateSortSettings;
const { data, loading, error, refetch } = requestManager.useGetMigratableSources({ const { data, loading, error, refetch } = requestManager.useGetMigratableSources();
notifyOnNetworkStatusChange: true,
});
const migratableSources = useMemo( const migratableSources = useMemo(
() => getMigratableSources(data?.mangas.nodes, migrateSortSettings), () => getMigratableSources(data?.mangas.nodes, migrateSortSettings),
[data?.mangas.nodes, migrateSortSettings], [data?.mangas.nodes, migrateSortSettings],

View File

@@ -174,7 +174,7 @@ export const useDefaultReaderSettings = (
loading: boolean; loading: boolean;
request: ReturnType<typeof requestManager.useGetGlobalMeta>; request: ReturnType<typeof requestManager.useGetGlobalMeta>;
} => { } => {
const request = requestManager.useGetGlobalMeta({ notifyOnNetworkStatusChange: true }); const request = requestManager.useGetGlobalMeta();
const { data, loading } = request; const { data, loading } = request;
const metadata = useMemo(() => convertFromGqlMeta(data?.metas.nodes), [data?.metas.nodes]); const metadata = useMemo(() => convertFromGqlMeta(data?.metas.nodes), [data?.metas.nodes]);
const metaHolder: MetadataHolder = useMemo(() => ({ meta: metadata }), [metadata]); const metaHolder: MetadataHolder = useMemo(() => ({ meta: metadata }), [metadata]);
@@ -200,7 +200,7 @@ export const useDefaultReaderSettingsWithDefaultFlag = (
loading: boolean; loading: boolean;
request: ReturnType<typeof requestManager.useGetGlobalMeta>; request: ReturnType<typeof requestManager.useGetGlobalMeta>;
} => { } => {
const request = requestManager.useGetGlobalMeta({ notifyOnNetworkStatusChange: true }); const request = requestManager.useGetGlobalMeta();
const { data, loading } = request; const { data, loading } = request;
const metadata = useMemo(() => convertFromGqlMeta(data?.metas.nodes), [data?.metas.nodes]); const metadata = useMemo(() => convertFromGqlMeta(data?.metas.nodes), [data?.metas.nodes]);
const metaHolder: MetadataHolder = useMemo(() => ({ meta: metadata }), [metadata]); const metaHolder: MetadataHolder = useMemo(() => ({ meta: metadata }), [metadata]);

View File

@@ -28,20 +28,20 @@ export function About() {
useAppTitle(t`About`); useAppTitle(t`About`);
const { data, loading, error, refetch } = requestManager.useGetAbout({ notifyOnNetworkStatusChange: true }); const { data, loading, error, refetch } = requestManager.useGetAbout();
const { const {
data: serverUpdateCheckData, data: serverUpdateCheckData,
loading: isCheckingForServerUpdate, loading: isCheckingForServerUpdate,
refetch: checkForServerUpdate, refetch: checkForServerUpdate,
error: serverUpdateCheckError, error: serverUpdateCheckError,
} = requestManager.useCheckForServerUpdate({ notifyOnNetworkStatusChange: true }); } = requestManager.useCheckForServerUpdate();
const { const {
data: webUIUpdateData, data: webUIUpdateData,
loading: isCheckingForWebUIUpdate, loading: isCheckingForWebUIUpdate,
refetch: checkForWebUIUpdate, refetch: checkForWebUIUpdate,
error: orgWebUIUpdateCheckError, error: orgWebUIUpdateCheckError,
} = requestManager.useCheckForWebUIUpdate({ notifyOnNetworkStatusChange: true }); } = requestManager.useCheckForWebUIUpdate();
const webUIUpdateCheckError = orgWebUIUpdateCheckError || webUIUpdateData?.checkForWebUIUpdate.tag === ''; const webUIUpdateCheckError = orgWebUIUpdateCheckError || webUIUpdateData?.checkForWebUIUpdate.tag === '';
const { data: webUIUpdateStatusData } = requestManager.useGetWebUIUpdateStatus(); const { data: webUIUpdateStatusData } = requestManager.useGetWebUIUpdateStatus();

View File

@@ -40,9 +40,7 @@ export const ImageProcessingSetting = ({ type }: { type: ImageProcessingType })
useAppTitle(t(IMAGE_PROCESSING_TYPE_TO_TRANSLATION[type])); useAppTitle(t(IMAGE_PROCESSING_TYPE_TO_TRANSLATION[type]));
const { data, loading, error, refetch } = requestManager.useGetServerSettings({ const { data, loading, error, refetch } = requestManager.useGetServerSettings();
notifyOnNetworkStatusChange: true,
});
const [mutateSettings] = requestManager.useUpdateServerSettings(); const [mutateSettings] = requestManager.useUpdateServerSettings();
const settingKey = IMAGE_PROCESSING_TYPE_TO_SETTING[type]; const settingKey = IMAGE_PROCESSING_TYPE_TO_SETTING[type];

View File

@@ -73,9 +73,7 @@ export const ServerSettings = () => {
loading: areServerSettingsLoading, loading: areServerSettingsLoading,
error: serverSettingsError, error: serverSettingsError,
refetch: refetchServerSettings, refetch: refetchServerSettings,
} = requestManager.useGetServerSettings({ } = requestManager.useGetServerSettings();
notifyOnNetworkStatusChange: true,
});
const [mutateSettings] = requestManager.useUpdateServerSettings(); const [mutateSettings] = requestManager.useUpdateServerSettings();
const koSyncStatus = requestManager.useKoSyncStatus(); const koSyncStatus = requestManager.useKoSyncStatus();

View File

@@ -54,9 +54,7 @@ export const WebUISettings = () => {
loading: areServerSettingsLoading, loading: areServerSettingsLoading,
error: serverSettingsError, error: serverSettingsError,
refetch: refetchServerSettings, refetch: refetchServerSettings,
} = requestManager.useGetServerSettings({ } = requestManager.useGetServerSettings();
notifyOnNetworkStatusChange: true,
});
const [mutateSettings] = requestManager.useUpdateServerSettings(); const [mutateSettings] = requestManager.useUpdateServerSettings();
const updateSetting = <Setting extends keyof WebUISettingsType>( const updateSetting = <Setting extends keyof WebUISettingsType>(

View File

@@ -38,7 +38,7 @@ export const useMetadataServerSettings = (): {
loading: boolean; loading: boolean;
request: ReturnType<typeof requestManager.useGetGlobalMeta>; request: ReturnType<typeof requestManager.useGetGlobalMeta>;
} => { } => {
const request = requestManager.useGetGlobalMeta({ notifyOnNetworkStatusChange: true }); const request = requestManager.useGetGlobalMeta();
const { data, loading } = request; const { data, loading } = request;
const metadata = useMemo(() => convertFromGqlMeta(data?.metas.nodes), [data?.metas.nodes]); const metadata = useMemo(() => convertFromGqlMeta(data?.metas.nodes), [data?.metas.nodes]);
const tmpSettings = getMetadataServerSettingsWithDefaultFallback(metadata, undefined, useEffect); const tmpSettings = getMetadataServerSettingsWithDefaultFallback(metadata, undefined, useEffect);

View File

@@ -56,9 +56,7 @@ export function SourceConfigure() {
const { data, loading, error, refetch } = requestManager.useGetSource< const { data, loading, error, refetch } = requestManager.useGetSource<
GetSourceSettingsQuery, GetSourceSettingsQuery,
GetCategoriesSettingsQueryVariables GetCategoriesSettingsQueryVariables
>(GET_SOURCE_SETTINGS, sourceId, { >(GET_SOURCE_SETTINGS, sourceId);
notifyOnNetworkStatusChange: true,
});
const sourcePreferences = data?.source.preferences ?? STABLE_EMPTY_ARRAY; const sourcePreferences = data?.source.preferences ?? STABLE_EMPTY_ARRAY;
const updateValue = const updateValue =

View File

@@ -44,9 +44,7 @@ export const TrackManga = ({ manga }: { manga: MangaIdInfo & Pick<MangaType, 'ti
const [searchModeForTracker, setSearchModeForTracker] = useState<number>(); const [searchModeForTracker, setSearchModeForTracker] = useState<number>();
const trackerList = requestManager.useGetTrackerList<GetTrackersBindQuery>(GET_TRACKERS_BIND, { const trackerList = requestManager.useGetTrackerList<GetTrackersBindQuery>(GET_TRACKERS_BIND);
notifyOnNetworkStatusChange: true,
});
const trackers = trackerList.data?.trackers.nodes ?? STABLE_EMPTY_ARRAY; const trackers = trackerList.data?.trackers.nodes ?? STABLE_EMPTY_ARRAY;
const mangaTrackRecordsList = requestManager.useGetManga<GetMangaTrackRecordsQuery>( const mangaTrackRecordsList = requestManager.useGetManga<GetMangaTrackRecordsQuery>(

View File

@@ -131,9 +131,7 @@ export const TrackerSearch = ({
const [selectedTrackerRemoteId, setSelectedTrackerRemoteId] = useState<string | undefined>(trackedId); const [selectedTrackerRemoteId, setSelectedTrackerRemoteId] = useState<string | undefined>(trackedId);
const trackerSearch = requestManager.useTrackerSearch(tracker.id, searchString, { const trackerSearch = requestManager.useTrackerSearch(tracker.id, searchString);
notifyOnNetworkStatusChange: true,
});
const searchResults = trackerSearch.data?.searchTracker.trackSearches ?? STABLE_EMPTY_ARRAY; const searchResults = trackerSearch.data?.searchTracker.trackSearches ?? STABLE_EMPTY_ARRAY;
const hasResults = !!searchResults.length; const hasResults = !!searchResults.length;

View File

@@ -48,9 +48,7 @@ export const TrackingSettings = () => {
loading: areTrackersLoading, loading: areTrackersLoading,
error: trackersError, error: trackersError,
refetch: refetchTrackersList, refetch: refetchTrackersList,
} = requestManager.useGetTrackerList<GetTrackersSettingsQuery>(GET_TRACKERS_SETTINGS, { } = requestManager.useGetTrackerList<GetTrackersSettingsQuery>(GET_TRACKERS_SETTINGS);
notifyOnNetworkStatusChange: true,
});
const trackers = data?.trackers.nodes ?? STABLE_EMPTY_ARRAY; const trackers = data?.trackers.nodes ?? STABLE_EMPTY_ARRAY;
const loading = areMetadataServerSettingsLoading || areTrackersLoading; const loading = areMetadataServerSettingsLoading || areTrackersLoading;

View File

@@ -39,7 +39,6 @@ export const Updates: React.FC = () => {
refetch, refetch,
} = requestManager.useGetRecentlyUpdatedChapters(undefined, { } = requestManager.useGetRecentlyUpdatedChapters(undefined, {
fetchPolicy: 'cache-and-network', fetchPolicy: 'cache-and-network',
notifyOnNetworkStatusChange: true,
}); });
const hasNextPage = !!chapterUpdateData?.chapters.pageInfo.hasNextPage; const hasNextPage = !!chapterUpdateData?.chapters.pageInfo.hasNextPage;
const endCursor = chapterUpdateData?.chapters.pageInfo.endCursor; const endCursor = chapterUpdateData?.chapters.pageInfo.endCursor;