Remove enabling notifyOnNetworkStatusChange usages

Starting with v4 this flag is now enabled by default
2026-05-02 17:37:38 +02:00
parent 515c402aca
commit 00bba202ef
28 changed files with 26 additions and 70 deletions
--- a/src/features/app-updates/components/ServerUpdateChecker.tsx
+++ b/src/features/app-updates/components/ServerUpdateChecker.tsx
@@ -41,7 +41,6 @@ export const ServerUpdateChecker = () => {
        error: serverUpdateCheckError,
        refetch: checkForUpdate,
    } = requestManager.useCheckForServerUpdate({
-        notifyOnNetworkStatusChange: true,
        fetchPolicy: 'cache-only',
    });

--- a/src/features/app-updates/components/WebUIUpdateChecker.tsx
+++ b/src/features/app-updates/components/WebUIUpdateChecker.tsx
@@ -57,7 +57,6 @@ export const WebUIUpdateChecker = () => {
    const { aboutWebUI } = aboutData ?? STABLE_EMPTY_OBJECT;

    const { data: webUIUpdateData, refetch: checkForUpdate } = requestManager.useCheckForWebUIUpdate({
-        notifyOnNetworkStatusChange: true,
        fetchPolicy: 'cache-only',
    });

--- a/src/features/backup/screens/Backup.tsx
+++ b/src/features/backup/screens/Backup.tsx
@@ -53,12 +53,7 @@ export function Backup() {

    useAppTitle(t`Backup`);

-    const {
-        data: settingsData,
-        loading,
-        error,
-        refetch,
-    } = requestManager.useGetServerSettings({ notifyOnNetworkStatusChange: true });
+    const { data: settingsData, loading, error, refetch } = requestManager.useGetServerSettings();
    const [mutateSettings] = requestManager.useUpdateServerSettings();

    const { data } = requestManager.useGetBackupRestoreStatus(backupRestoreId ?? '', {
--- a/src/features/browse/extensions/Extensions.tsx
+++ b/src/features/browse/extensions/Extensions.tsx
@@ -121,7 +121,7 @@ export function Extensions({ tabsMenuHeight }: { tabsMenuHeight: number }) {
        loading: areServerSettingsLoading,
        error: serverSettingsError,
        refetch: refetchServerSettings,
-    } = requestManager.useGetServerSettings({ notifyOnNetworkStatusChange: true });
+    } = requestManager.useGetServerSettings();
    const [fetchExtensions, { data, loading: areExtensionsLoading, error: extensionsError }] =
        requestManager.useExtensionListFetch();

--- a/src/features/browse/screens/BrowseSettings.tsx
+++ b/src/features/browse/screens/BrowseSettings.tsx
@@ -36,9 +36,7 @@ export const BrowseSettings = () => {

    useAppTitle(t`Browse`);

-    const { data, loading, error, refetch } = requestManager.useGetServerSettings({
-        notifyOnNetworkStatusChange: true,
-    });
+    const { data, loading, error, refetch } = requestManager.useGetServerSettings();
    const [mutateSettings] = requestManager.useUpdateServerSettings();

    const updateSetting = <Setting extends keyof ExtensionsSettings>(
--- a/src/features/browse/sources/Sources.tsx
+++ b/src/features/browse/sources/Sources.tsx
@@ -40,12 +40,7 @@ export function Sources({ tabsMenuHeight }: { tabsMenuHeight: number }) {
        settings: { showNsfw, lastUsedSourceId },
    } = useMetadataServerSettings();

-    const {
-        data,
-        loading: isLoading,
-        error,
-        refetch,
-    } = requestManager.useGetSourceList({ notifyOnNetworkStatusChange: true });
+    const { data, loading: isLoading, error, refetch } = requestManager.useGetSourceList();
    const sources = data?.sources.nodes ?? STABLE_EMPTY_ARRAY;
    const filteredSources = useMemo(
        () =>
--- a/src/features/category/screens/CategorySettings.tsx
+++ b/src/features/category/screens/CategorySettings.tsx
@@ -44,7 +44,7 @@ export function CategorySettings() {
    const { data, loading, error, refetch } = requestManager.useGetCategories<
        GetCategoriesSettingsQuery,
        GetCategoriesSettingsQueryVariables
-    >(GET_CATEGORIES_SETTINGS, { notifyOnNetworkStatusChange: true });
+    >(GET_CATEGORIES_SETTINGS);
    const [reorderCategory, { reset: revertReorder }] = requestManager.useReorderCategory();

    const [categoryToEdit, setCategoryToEdit] = useState<number>(CREATE_NEW_CATEGORY_ID);
--- a/src/features/chapter/components/ChapterList.tsx
+++ b/src/features/chapter/components/ChapterList.tsx
@@ -139,7 +139,6 @@ export const ChapterList = ({
    } = requestManager.useGetMangaChapters<GetChaptersMangaQuery, GetChaptersMangaQueryVariables>(
        GET_CHAPTERS_MANGA,
        manga.id,
-        { notifyOnNetworkStatusChange: true },
    );
    const chapters = chaptersData?.chapters.nodes ?? STABLE_EMPTY_ARRAY;

--- a/src/features/downloads/screens/DownloadQueue.tsx
+++ b/src/features/downloads/screens/DownloadQueue.tsx
@@ -42,12 +42,7 @@ export const DownloadQueue: React.FC = () => {

    const [reorderDownload, { reset: revertReorder }] = requestManager.useReorderChapterInDownloadQueue();

-    const {
-        data: downloadStatusData,
-        loading: isLoading,
-        error,
-        refetch,
-    } = requestManager.useGetDownloadStatus({ notifyOnNetworkStatusChange: true });
+    const { data: downloadStatusData, loading: isLoading, error, refetch } = requestManager.useGetDownloadStatus();
    const downloaderData = downloadStatusData?.downloadStatus;

    const queue = downloaderData?.queue ?? STABLE_EMPTY_ARRAY;
--- a/src/features/downloads/screens/DownloadSettings.tsx
+++ b/src/features/downloads/screens/DownloadSettings.tsx
@@ -58,7 +58,7 @@ export const DownloadSettings = () => {
    const categories = requestManager.useGetCategories<GetCategoriesSettingsQuery, GetCategoriesSettingsQueryVariables>(
        GET_CATEGORIES_SETTINGS,
    );
-    const serverSettings = requestManager.useGetServerSettings({ notifyOnNetworkStatusChange: true });
+    const serverSettings = requestManager.useGetServerSettings();
    const [mutateSettings] = requestManager.useUpdateServerSettings();
    const {
        settings: metadataSettings,
--- a/src/features/global-search/screens/SearchAll.tsx
+++ b/src/features/global-search/screens/SearchAll.tsx
@@ -265,7 +265,7 @@ export const SearchAll = ({
        settings: { showNsfw, shouldShowOnlySourcesWithResults },
    } = useMetadataServerSettings();

-    const { data, loading, error, refetch } = requestManager.useGetSourceList({ notifyOnNetworkStatusChange: true });
+    const { data, loading, error, refetch } = requestManager.useGetSourceList();
    const tmpSources = data?.sources.nodes ?? STABLE_EMPTY_ARRAY;
    const sources = useMemo(
        () =>
--- a/src/features/history/screens/History.tsx
+++ b/src/features/history/screens/History.tsx
@@ -36,7 +36,6 @@ export const History: React.FC = () => {
        refetch,
    } = requestManager.useGetRecentlyReadChapters(undefined, {
        fetchPolicy: 'cache-and-network',
-        notifyOnNetworkStatusChange: true,
    });
    const hasNextPage = !!chapterHistoryData?.chapters.pageInfo.hasNextPage;
    const endCursor = chapterHistoryData?.chapters.pageInfo.endCursor;
--- a/src/features/library/screens/Library.tsx
+++ b/src/features/library/screens/Library.tsx
@@ -76,9 +76,6 @@ export function Library() {
        refetch: refetchCategories,
    } = requestManager.useGetCategories<GetCategoriesLibraryQuery, GetCategoriesLibraryQueryVariables>(
        GET_CATEGORIES_LIBRARY,
-        {
-            notifyOnNetworkStatusChange: true,
-        },
    );
    const tabsData = categoriesResponse?.categories.nodes.filter(
        (category) => category.id !== 0 || (category.id === 0 && category.mangas.totalCount),
@@ -102,7 +99,7 @@ export function Library() {
        error: mangaError,
        loading: mangaLoading,
        refetch: refetchCategoryMangas,
-    } = requestManager.useGetCategoryMangas(activeTab?.id, { skip: !activeTab, notifyOnNetworkStatusChange: true });
+    } = requestManager.useGetCategoryMangas(activeTab?.id, { skip: !activeTab });
    const categoryMangas = categoryMangaResponse?.mangas.nodes ?? STABLE_EMPTY_ARRAY;
    const {
        visibleMangas: mangas,
--- a/src/features/library/screens/LibrarySettings.tsx
+++ b/src/features/library/screens/LibrarySettings.tsx
@@ -74,7 +74,7 @@ export function LibrarySettings() {
    const categories = requestManager.useGetCategories<GetCategoriesSettingsQuery, GetCategoriesSettingsQueryVariables>(
        GET_CATEGORIES_SETTINGS,
    );
-    const serverSettings = requestManager.useGetServerSettings({ notifyOnNetworkStatusChange: true });
+    const serverSettings = requestManager.useGetServerSettings();
    const {
        settings,
        loading: areMetadataServerSettingsLoading,
--- a/src/features/migration/screens/MigrationSelectDestinationSources.tsx
+++ b/src/features/migration/screens/MigrationSelectDestinationSources.tsx
@@ -44,9 +44,7 @@ export const MigrationSelectDestinationSources = () => {
        loading: areSourcesLoading,
        error: sourceError,
        refetch: refetchSources,
-    } = requestManager.useGetSourceList({
-        notifyOnNetworkStatusChange: true,
-    });
+    } = requestManager.useGetSourceList();

    const allSources = data?.sources.nodes ?? STABLE_EMPTY_ARRAY;
    const sources = useMemo(
--- a/src/features/migration/screens/MigrationSelectMangas.tsx
+++ b/src/features/migration/screens/MigrationSelectMangas.tsx
@@ -58,7 +58,7 @@ export const MigrationSelectMangas = () => {
    } = requestManager.useGetSource<GetSourceMigratableQuery, GetSourceMigratableQueryVariables>(
        GET_SOURCE_MIGRATABLE,
        sourceId ?? '',
-        { skip: !sourceIds, notifyOnNetworkStatusChange: true },
+        { skip: !sourceIds },
    );

    const {
@@ -68,7 +68,6 @@ export const MigrationSelectMangas = () => {
        refetch: refetchMangas,
    } = requestManager.useGetMigratableSourceMangas(sourceId!, {
        skip: !sourceIds,
-        notifyOnNetworkStatusChange: true,
    });

    const mangas = migratableSourceMangasData?.mangas.nodes ?? STABLE_EMPTY_ARRAY;
--- a/src/features/migration/screens/MigrationSelectSource.tsx
+++ b/src/features/migration/screens/MigrationSelectSource.tsx
@@ -91,9 +91,7 @@ export const MigrationSelectSource = ({ tabsMenuHeight }: { tabsMenuHeight: numb
    );
    const { sortBy, sortOrder } = migrateSortSettings;

-    const { data, loading, error, refetch } = requestManager.useGetMigratableSources({
-        notifyOnNetworkStatusChange: true,
-    });
+    const { data, loading, error, refetch } = requestManager.useGetMigratableSources();
    const migratableSources = useMemo(
        () => getMigratableSources(data?.mangas.nodes, migrateSortSettings),
        [data?.mangas.nodes, migrateSortSettings],
--- a/src/features/reader/settings/ReaderSettingsMetadata.ts
+++ b/src/features/reader/settings/ReaderSettingsMetadata.ts
@@ -174,7 +174,7 @@ export const useDefaultReaderSettings = (
    loading: boolean;
    request: ReturnType<typeof requestManager.useGetGlobalMeta>;
 } => {
-    const request = requestManager.useGetGlobalMeta({ notifyOnNetworkStatusChange: true });
+    const request = requestManager.useGetGlobalMeta();
    const { data, loading } = request;
    const metadata = useMemo(() => convertFromGqlMeta(data?.metas.nodes), [data?.metas.nodes]);
    const metaHolder: MetadataHolder = useMemo(() => ({ meta: metadata }), [metadata]);
@@ -200,7 +200,7 @@ export const useDefaultReaderSettingsWithDefaultFlag = (
    loading: boolean;
    request: ReturnType<typeof requestManager.useGetGlobalMeta>;
 } => {
-    const request = requestManager.useGetGlobalMeta({ notifyOnNetworkStatusChange: true });
+    const request = requestManager.useGetGlobalMeta();
    const { data, loading } = request;
    const metadata = useMemo(() => convertFromGqlMeta(data?.metas.nodes), [data?.metas.nodes]);
    const metaHolder: MetadataHolder = useMemo(() => ({ meta: metadata }), [metadata]);
--- a/src/features/settings/screens/About.tsx
+++ b/src/features/settings/screens/About.tsx
@@ -28,20 +28,20 @@ export function About() {

    useAppTitle(t`About`);

-    const { data, loading, error, refetch } = requestManager.useGetAbout({ notifyOnNetworkStatusChange: true });
+    const { data, loading, error, refetch } = requestManager.useGetAbout();

    const {
        data: serverUpdateCheckData,
        loading: isCheckingForServerUpdate,
        refetch: checkForServerUpdate,
        error: serverUpdateCheckError,
-    } = requestManager.useCheckForServerUpdate({ notifyOnNetworkStatusChange: true });
+    } = requestManager.useCheckForServerUpdate();
    const {
        data: webUIUpdateData,
        loading: isCheckingForWebUIUpdate,
        refetch: checkForWebUIUpdate,
        error: orgWebUIUpdateCheckError,
-    } = requestManager.useCheckForWebUIUpdate({ notifyOnNetworkStatusChange: true });
+    } = requestManager.useCheckForWebUIUpdate();
    const webUIUpdateCheckError = orgWebUIUpdateCheckError || webUIUpdateData?.checkForWebUIUpdate.tag === '';

    const { data: webUIUpdateStatusData } = requestManager.useGetWebUIUpdateStatus();
--- a/src/features/settings/screens/ImageProcessingSetting.tsx
+++ b/src/features/settings/screens/ImageProcessingSetting.tsx
@@ -40,9 +40,7 @@ export const ImageProcessingSetting = ({ type }: { type: ImageProcessingType })

    useAppTitle(t(IMAGE_PROCESSING_TYPE_TO_TRANSLATION[type]));

-    const { data, loading, error, refetch } = requestManager.useGetServerSettings({
-        notifyOnNetworkStatusChange: true,
-    });
+    const { data, loading, error, refetch } = requestManager.useGetServerSettings();
    const [mutateSettings] = requestManager.useUpdateServerSettings();

    const settingKey = IMAGE_PROCESSING_TYPE_TO_SETTING[type];
--- a/src/features/settings/screens/ServerSettings.tsx
+++ b/src/features/settings/screens/ServerSettings.tsx
@@ -73,9 +73,7 @@ export const ServerSettings = () => {
        loading: areServerSettingsLoading,
        error: serverSettingsError,
        refetch: refetchServerSettings,
-    } = requestManager.useGetServerSettings({
-        notifyOnNetworkStatusChange: true,
-    });
+    } = requestManager.useGetServerSettings();
    const [mutateSettings] = requestManager.useUpdateServerSettings();

    const koSyncStatus = requestManager.useKoSyncStatus();
--- a/src/features/settings/screens/WebUISettings.tsx
+++ b/src/features/settings/screens/WebUISettings.tsx
@@ -54,9 +54,7 @@ export const WebUISettings = () => {
        loading: areServerSettingsLoading,
        error: serverSettingsError,
        refetch: refetchServerSettings,
-    } = requestManager.useGetServerSettings({
-        notifyOnNetworkStatusChange: true,
-    });
+    } = requestManager.useGetServerSettings();
    const [mutateSettings] = requestManager.useUpdateServerSettings();

    const updateSetting = <Setting extends keyof WebUISettingsType>(
--- a/src/features/settings/services/ServerSettingsMetadata.ts
+++ b/src/features/settings/services/ServerSettingsMetadata.ts
@@ -38,7 +38,7 @@ export const useMetadataServerSettings = (): {
    loading: boolean;
    request: ReturnType<typeof requestManager.useGetGlobalMeta>;
 } => {
-    const request = requestManager.useGetGlobalMeta({ notifyOnNetworkStatusChange: true });
+    const request = requestManager.useGetGlobalMeta();
    const { data, loading } = request;
    const metadata = useMemo(() => convertFromGqlMeta(data?.metas.nodes), [data?.metas.nodes]);
    const tmpSettings = getMetadataServerSettingsWithDefaultFallback(metadata, undefined, useEffect);
--- a/src/features/source/configuration/screens/SourceConfigure.tsx
+++ b/src/features/source/configuration/screens/SourceConfigure.tsx
@@ -56,9 +56,7 @@ export function SourceConfigure() {
    const { data, loading, error, refetch } = requestManager.useGetSource<
        GetSourceSettingsQuery,
        GetCategoriesSettingsQueryVariables
-    >(GET_SOURCE_SETTINGS, sourceId, {
-        notifyOnNetworkStatusChange: true,
-    });
+    >(GET_SOURCE_SETTINGS, sourceId);
    const sourcePreferences = data?.source.preferences ?? STABLE_EMPTY_ARRAY;

    const updateValue =
--- a/src/features/tracker/components/TrackManga.tsx
+++ b/src/features/tracker/components/TrackManga.tsx
@@ -44,9 +44,7 @@ export const TrackManga = ({ manga }: { manga: MangaIdInfo & Pick<MangaType, 'ti

    const [searchModeForTracker, setSearchModeForTracker] = useState<number>();

-    const trackerList = requestManager.useGetTrackerList<GetTrackersBindQuery>(GET_TRACKERS_BIND, {
-        notifyOnNetworkStatusChange: true,
-    });
+    const trackerList = requestManager.useGetTrackerList<GetTrackersBindQuery>(GET_TRACKERS_BIND);
    const trackers = trackerList.data?.trackers.nodes ?? STABLE_EMPTY_ARRAY;

    const mangaTrackRecordsList = requestManager.useGetManga<GetMangaTrackRecordsQuery>(
--- a/src/features/tracker/components/TrackerSearch.tsx
+++ b/src/features/tracker/components/TrackerSearch.tsx
@@ -131,9 +131,7 @@ export const TrackerSearch = ({

    const [selectedTrackerRemoteId, setSelectedTrackerRemoteId] = useState<string | undefined>(trackedId);

-    const trackerSearch = requestManager.useTrackerSearch(tracker.id, searchString, {
-        notifyOnNetworkStatusChange: true,
-    });
+    const trackerSearch = requestManager.useTrackerSearch(tracker.id, searchString);
    const searchResults = trackerSearch.data?.searchTracker.trackSearches ?? STABLE_EMPTY_ARRAY;

    const hasResults = !!searchResults.length;
--- a/src/features/tracker/screens/TrackingSettings.tsx
+++ b/src/features/tracker/screens/TrackingSettings.tsx
@@ -48,9 +48,7 @@ export const TrackingSettings = () => {
        loading: areTrackersLoading,
        error: trackersError,
        refetch: refetchTrackersList,
-    } = requestManager.useGetTrackerList<GetTrackersSettingsQuery>(GET_TRACKERS_SETTINGS, {
-        notifyOnNetworkStatusChange: true,
-    });
+    } = requestManager.useGetTrackerList<GetTrackersSettingsQuery>(GET_TRACKERS_SETTINGS);
    const trackers = data?.trackers.nodes ?? STABLE_EMPTY_ARRAY;

    const loading = areMetadataServerSettingsLoading || areTrackersLoading;
--- a/src/features/updates/screens/Updates.tsx
+++ b/src/features/updates/screens/Updates.tsx
@@ -39,7 +39,6 @@ export const Updates: React.FC = () => {
        refetch,
    } = requestManager.useGetRecentlyUpdatedChapters(undefined, {
        fetchPolicy: 'cache-and-network',
-        notifyOnNetworkStatusChange: true,
    });
    const hasNextPage = !!chapterUpdateData?.chapters.pageInfo.hasNextPage;
    const endCursor = chapterUpdateData?.chapters.pageInfo.endCursor;