Commit Graph

2360 Commits

Author SHA1 Message Date
schroda
040584989e Migrate metadata once instead of when reading a value 2025-01-05 14:54:37 +01:00
schroda
258b26f837 Remove unnecessary function exports 2025-01-05 14:54:20 +01:00
schroda
65da9db123 Correctly read last applied migration id from metadata 2025-01-05 14:53:52 +01:00
schroda
1533e37623 Add "migration" to global metadata keys 2025-01-04 21:31:47 +01:00
schroda
a51d81d267 Extract "MetadataReader" functions 2025-01-04 21:28:26 +01:00
schroda
b7971f5183 Move "getAppMetadataFrom" to "MetadataMigrations" 2025-01-04 21:27:51 +01:00
schroda
3782091601 Remove metadata "applyMigration" option 2025-01-04 21:23:05 +01:00
schroda
8ae8cfa140 Fix tsc issues 2025-01-04 20:59:18 +01:00
schroda
1b1ddeb334 Show "info" toast severity by default
The default severity of MUI is "success"
2025-01-04 16:28:16 +01:00
schroda
afeb0f9aca Correctly check if chapter exists
The wrong chapter list was used.
"chapters" is the filtered list of chapters, which e.g. doesn't contain duplicated chapters.
This caused the "chapter source order" to potentially be higher than the total chapters of the manga.

The end result of this was that the fetched state of the pages wasn't properly detected causing errors due to rendering the reader before it was in the correct state
2025-01-04 15:58:33 +01:00
schroda
62155005ab Apply auto vertical progress bar for BOTTOM position only
In case "auto vertical position" is not "OFF" but the main position is not "BOTTOM", the auto mode still should be considered to be "OFF"
2025-01-02 22:22:31 +01:00
schroda
52f5415c9f Memoize mobile progress bar position related styling
Only really relevant for the "progress bar slot" prop to prevent the slots from unnecessary re-rendering, since depending on the total pages, this can impact the render performance on page changes heavily
2025-01-02 22:22:30 +01:00
schroda
b5a0ec7371 Ignore reading direction for vertical progress bar
The page change handling of the progress bar was inverted while RTL was the set readers reading direction.
However, this is only relevant for the horizontal progress bar
2025-01-02 21:48:23 +01:00
schroda
f90e4597f8 Make mobile progress bar position changeable 2025-01-02 21:48:02 +01:00
schroda
92892e6604 Optionally adjust progress bar position based on available size 2025-01-02 21:26:19 +01:00
schroda
4aa144cb25 Make minimized standard progress bar gaps transparent 2025-01-02 14:43:01 +01:00
schroda
87a1a67880 Use static hide timeout for all reader setting previews
The default timeout of "notistack" is 5s by default, however, this makes it more clear and also prevents any behaviour changes in the future, in case the default timeout gets changed
2025-01-02 03:22:25 +01:00
schroda
af8ada9a62 Always add close button to snackbars 2025-01-02 03:04:14 +01:00
schroda
ed992046cb Remove unintentional touch bindings
Caused double clicks
2025-01-02 02:41:42 +01:00
schroda
2944252d91 Make chapter transition warnings optional 2025-01-01 17:24:36 +01:00
schroda
e199b75756 Show correct download queue removal failure 2025-01-01 16:44:18 +01:00
schroda
f13e8eb412 Fix converting pages to double page mode 2024-12-31 17:17:54 +01:00
schroda
f3792edac0 Ignore visible transition pages on page change in continuous pager 2024-12-31 17:03:42 +01:00
schroda
886cc469bc Fix TypeError when reaching scroll end in continuous pager
When the end of the scrollable element is reached in the continuous reader, the last image is not visible anymore.
Thus, the "firstVisibleImageIndex" is invalid and gets incorrectly used for the "isEndReached" case which results in an TypeError when trying to use the actual page via the index
2024-12-31 16:54:21 +01:00
schroda
8c147b797a Properly detect if image fills whole viewport
The thresholds are only for detecting if a specific side of the image is in the viewport.

For the check if the image fills the whole viewport, the thresholds incorrectly detect this depending on the readers reading direction.

E.g. in the continuous horizontal pager with theme direction LTR and reader reading direction RTL, the left threshold will be the total width of the viewport plus one which will lead to out of view images to be detected as completely filling the viewport
2024-12-31 16:51:28 +01:00
schroda
d6a3d02189 Fix page jumping when scrolling continuous pagers
Both hardcoded thresholds (MIN_VISIBLE_PX 0 or 1) break the "first visible image" detection in different kind of ways.

With 1 it always incorrectly jumps to the next page when resuming a chapter, since the page to resume will bet at 0px.

With 0 it fails to detect the correct first visible image when scrolling (automatically not via wheel or touch) to another page.
This happens when there is no gap between the pages because in this case the start of the current image and the end of the previous image are at the same coordinate.
Thus, the previous image is still incorrectly detected as visible since the end still aligns with the viewports start/end
2024-12-31 16:43:46 +01:00
schroda
c2c4115c9c Reset reader settings state on exit 2024-12-31 14:52:50 +01:00
schroda
7f04f1c860 Consider unset reader chapter as still loading
In case the "currentChapter" is undefined, it means that the state has not been set yet.
In case the "currentChapter" does not exist, it would be set to "null".
2024-12-31 14:52:49 +01:00
schroda
83e8a5fec1 Correctly check if reader chapter exists
As explained in c70287363a8e9308fc294baf83c5656a21a479b1, the "chapterSourceOrder" does not start at 0, thus, in case it's the last known chapter, "doesChapterExist" was always false due to subtracting 1 of the total chapters
2024-12-31 14:52:48 +01:00
schroda
899364ac85 Use proper name for reader url chapter "index" param
It's not the index of the chapter but the source order, which is starting at 1 and not 0
2024-12-31 14:52:47 +01:00
schroda
17cf8ec9d0 Update "pagesToSpreadState" during render
Gets rid of an unnecessary rendering
2024-12-31 13:25:37 +01:00
schroda
3bab657c52 Update "actualPages" immediately
Instead of immediately updating the value once the page count changed, it got updated after "pagesToSpreadState" changed, which was after the rendering finished.

This was the actual root cause of what was tried to be fixed with 9ab6ec89c7
2024-12-31 13:24:29 +01:00
schroda
36ae02d2bd Revert "Fix page resume in continuous pagers"
This reverts commit 9ab6ec89c7.
2024-12-31 12:46:25 +01:00
schroda
8594a7b178 Increase reserved "current page" text for double pager
For the double pager the current page text needs more reserved space since two pages are displayed at once which changes the current page text to "<page1>-<page2>" instead of just "<page1>"
2024-12-31 04:38:11 +01:00
schroda
a0df80f60a Fix opening previous/next page via user action
Regression 55dc9471d9
2024-12-31 04:24:47 +01:00
schroda
9ab6ec89c7 Fix page resume in continuous pagers
The image refs weren't always set by the time the last read page got resumed.
Thus, the last read page never got scrolled into view
2024-12-31 04:05:53 +01:00
schroda
f808614e6c Prevent layout shifts in continuous pagers
I was unable to find a fix for this problem, thus, the only solution I see is disabling this functionality for the continuous readers.

Due to preloading leading pages, the layout got shifted once the pages got loaded.
This messed with the scroll position which caused the top of the scrolled into views pages to not be at the top of the viewport anymore.
2024-12-31 02:51:20 +01:00
schroda
1d955257dd Prevent page jump on scroll to page
When an unloaded page got scrolled into view, the current page got incorrectly set to the next page once the page got loaded
2024-12-31 02:46:07 +01:00
schroda
d885b4904e Render pages only once reader settings have been set
For the reader to be ready it's necessary that the settings not only have been loaded but also that the settings context is properly set
2024-12-31 02:46:04 +01:00
schroda
283bc1f706 Wait till reader setting are set to show previews
Sometimes the reader settings state took too long to get set and the previews were shown using the default settings first, since they are set as the default values of the reader settings context, and then again for the final settings
2024-12-31 02:45:12 +01:00
schroda
14044af1cd Reset "transition page mode" on reader exit 2024-12-31 02:21:36 +01:00
schroda
740acf63fc Show default "reading mode" setting
Regression 6ca6864035
2024-12-31 01:08:13 +01:00
schroda
9b706d0c82 Delay "reading mode" and "tap zone" preview until reader is ready 2024-12-30 21:23:39 +01:00
schroda
f8d3be3911 Do not check for state change before set state call
Due to not including the states in the dependency array (to improve render performance), they do not include updated data and might cause an incorrect early exit.

E.g. in case a load error happened for a page whose loaded flag was already set to true, the pages load state never got updated again
2024-12-30 21:21:09 +01:00
schroda
95f95e770f Prevent TypeError and incorrect state updates for "pagesSpreadState"
Page spread state updates of an already closed chapter caused TypeErrors or incorrect state updates.
2024-12-30 21:03:13 +01:00
schroda
7c98bab43b Prevent TypeError and incorrect state updates for "pageLoadStates"
Page load state updates of an already closed chapter caused TypeErrors or incorrect state updates.
2024-12-30 21:03:10 +01:00
schroda
55dc9471d9 Hide chapter transition page in single/double pagers
Transition page got opened and never closed again due to not correctly detecting that a transition page is currently visible
2024-12-30 19:57:18 +01:00
schroda
1f3a3b6c39 Auto hide "tap zone layout" preview when opening reader 2024-12-30 19:41:49 +01:00
schroda
fa868ea222 Properly detect "reading mode" and "tap zone" changes for preview 2024-12-30 19:33:37 +01:00
schroda
45f46a05d0 Optionally show preview or "reading mode" and "tap zone overlay"
Shows a preview when opening the reader or when the values change
2024-12-30 16:51:39 +01:00