Move "Mangas.ts" types and constants to new files

src/modules/manga/Manga.constants.ts

@@ -6,4 +6,94 @@
  * file, You can obtain one at https://mozilla.org/MPL/2.0/.
  */
 
+import { MangaStatus } from '@/lib/graphql/generated/graphql.ts';
+import { TranslationKey } from '@/Base.types.ts';
+import { MangaAction } from '@/modules/manga/Manga.types.ts';
+
 export const MANGA_COVER_ASPECT_RATIO = '1 / 1.5';
+
+export const statusToTranslationKey: Record<MangaStatus, TranslationKey> = {
+    [MangaStatus.Cancelled]: 'manga.status.cancelled',
+    [MangaStatus.Completed]: 'manga.status.completed',
+    [MangaStatus.Licensed]: 'manga.status.licensed',
+    [MangaStatus.Ongoing]: 'manga.status.ongoing',
+    [MangaStatus.OnHiatus]: 'manga.status.hiatus',
+    [MangaStatus.PublishingFinished]: 'manga.status.publishing_finished',
+    [MangaStatus.Unknown]: 'manga.status.unknown',
+};
+
+export const actionToTranslationKey: {
+    [key in MangaAction]: {
+        action: {
+            single: TranslationKey;
+            selected: TranslationKey;
+        };
+        success: TranslationKey;
+        error: TranslationKey;
+    };
+} = {
+    download: {
+        action: {
+            single: 'chapter.action.download.add.label.action',
+            selected: 'chapter.action.download.add.button.selected',
+        },
+        success: 'chapter.action.download.add.label.success',
+        error: 'chapter.action.download.add.label.error',
+    },
+    delete: {
+        action: {
+            single: 'chapter.action.download.delete.label.action',
+            selected: 'chapter.action.download.delete.button.selected',
+        },
+        success: 'chapter.action.download.delete.label.success',
+        error: 'chapter.action.download.delete.label.error',
+    },
+    mark_as_read: {
+        action: {
+            single: 'chapter.action.mark_as_read.add.label.action.current',
+            selected: 'chapter.action.mark_as_read.add.button.selected',
+        },
+        success: 'chapter.action.mark_as_read.add.label.success',
+        error: 'chapter.action.mark_as_read.add.label.error',
+    },
+    mark_as_unread: {
+        action: {
+            single: 'chapter.action.mark_as_read.remove.label.action',
+            selected: 'chapter.action.mark_as_read.remove.button.selected',
+        },
+        success: 'chapter.action.mark_as_read.remove.label.success',
+        error: 'chapter.action.mark_as_read.remove.label.error',
+    },
+    remove_from_library: {
+        action: {
+            single: 'manga.action.library.remove.label.action',
+            selected: 'manga.action.library.remove.button.selected',
+        },
+        success: 'manga.action.library.remove.label.success',
+        error: 'manga.action.library.remove.label.error',
+    },
+    change_categories: {
+        action: {
+            single: 'manga.action.category.label.action',
+            selected: 'manga.action.category.button.selected',
+        },
+        success: 'manga.action.category.label.success',
+        error: 'manga.action.category.label.error',
+    },
+    migrate: {
+        action: {
+            single: 'global.button.migrate',
+            selected: 'global.button.migrate', // not supported
+        },
+        success: 'manga.action.migrate.label.success',
+        error: 'manga.action.migrate.label.error',
+    },
+    track: {
+        action: {
+            single: 'manga.action.track.add.label.action',
+            selected: 'manga.action.track.add.label.action', // not supported
+        },
+        success: 'manga.action.track.add.label.success',
+        error: 'manga.action.track.add.label.error',
+    },
+};

src/modules/manga/Manga.types.ts

@@ -11,8 +11,7 @@ import { PopupState } from 'material-ui-popup-state/hooks';
 import { GridLayout } from '@/modules/library/contexts/LibraryOptionsContext.tsx';
 import { SelectableCollectionReturnType } from '@/modules/collection/hooks/useSelectableCollection.ts';
 import { useManageMangaLibraryState } from '@/modules/manga/hooks/useManageMangaLibraryState.tsx';
-import { MangaThumbnailInfo } from '@/modules/manga/services/Mangas.ts';
-import { ChapterType, MangaType } from '@/lib/graphql/generated/graphql.ts';
+import { ChapterType, MangaReaderFieldsFragment, MangaType, TrackRecordType } from '@/lib/graphql/generated/graphql.ts';
 import { SingleModeProps } from '@/modules/manga/components/MangaActionMenuItems.tsx';
 import { IReaderSettings } from '@/modules/reader/Reader.types';
 
@@ -24,6 +23,17 @@ type MangaCardBaseProps = Pick<MangaType, 'id' | 'title' | 'sourceId'> &
         firstUnreadChapter?: Pick<ChapterType, 'id' | 'sourceOrder'> | null;
     };
 
+export type MangaIdInfo = Pick<MangaType, 'id'>;
+export type MangaChapterCountInfo = { chapters: Pick<MangaType['chapters'], 'totalCount'> };
+export type MangaDownloadInfo = Pick<MangaType, 'downloadCount'> & MangaChapterCountInfo;
+export type MangaUnreadInfo = Pick<MangaType, 'unreadCount'> & MangaChapterCountInfo;
+export type MangaThumbnailInfo = Pick<MangaType, 'thumbnailUrl' | 'thumbnailUrlLastFetched'>;
+export type MangaTrackRecordInfo = MangaIdInfo & {
+    trackRecords: { nodes: Pick<TrackRecordType, 'id' | 'trackerId'>[] };
+};
+
+export type MigrateMode = 'copy' | 'migrate';
+
 type MangaCardSpecificProps = MangaCardBaseProps & MangaThumbnailInfo;
 
 export interface MangaCardProps {
@@ -47,3 +57,15 @@ export type SpecificMangaCardProps = Omit<MangaCardProps, 'manga'> &
     };
 
 export type MangaMetadataKeys = keyof IReaderSettings;
+
+export type MangaAction =
+    | 'download'
+    | 'delete'
+    | 'mark_as_read'
+    | 'mark_as_unread'
+    | 'remove_from_library'
+    | 'change_categories'
+    | 'migrate'
+    | 'track';
+
+export type TMangaReader = MangaReaderFieldsFragment;

src/modules/manga/components/MangaActionMenuItems.tsx

@@ -19,14 +19,7 @@ import SyncAltIcon from '@mui/icons-material/SyncAlt';
 import { Link } from 'react-router-dom';
 import SyncIcon from '@mui/icons-material/Sync';
 import Dialog from '@mui/material/Dialog';
-import {
-    actionToTranslationKey,
-    MangaAction,
-    MangaDownloadInfo,
-    MangaIdInfo,
-    Mangas,
-    MangaUnreadInfo,
-} from '@/modules/manga/services/Mangas.ts';
+import { Mangas } from '@/modules/manga/services/Mangas.ts';
 import { SelectableCollectionReturnType } from '@/modules/collection/hooks/useSelectableCollection.ts';
 import { MenuItem } from '@/modules/core/components/menu/MenuItem.tsx';
 import {
@@ -40,6 +33,8 @@ import { useCategorySelect } from '@/modules/category/hooks/useCategorySelect.ts
 import { ChaptersDownloadActionMenuItems } from '@/modules/chapter/components/actions/ChaptersDownloadActionMenuItems.tsx';
 import { NestedMenuItem } from '@/modules/core/components/menu/NestedMenuItem.tsx';
 import { MangaChapterStatFieldsFragment, MangaType } from '@/lib/graphql/generated/graphql.ts';
+import { MangaAction, MangaDownloadInfo, MangaIdInfo, MangaUnreadInfo } from '@/modules/manga/Manga.types.ts';
+import { actionToTranslationKey } from '@/modules/manga/Manga.constants.ts';
 
 const ACTION_DISABLES_SELECTION_MODE: MangaAction[] = ['remove_from_library'] as const;
 

src/modules/manga/components/MangaDetails.tsx

@@ -27,12 +27,7 @@ import OpenInFullIcon from '@mui/icons-material/OpenInFull';
 import Modal from '@mui/material/Modal';
 import { bindPopover, bindTrigger, usePopupState } from 'material-ui-popup-state/hooks';
 import { makeToast } from '@/modules/core/utils/Toast.ts';
-import {
-    Mangas,
-    MangaThumbnailInfo,
-    MangaTrackRecordInfo,
-    statusToTranslationKey,
-} from '@/modules/manga/services/Mangas.ts';
+import { Mangas } from '@/modules/manga/services/Mangas.ts';
 import { SpinnerImage } from '@/modules/core/components/SpinnerImage.tsx';
 import { CustomIconButton } from '@/modules/core/components/buttons/CustomIconButton.tsx';
 import { TrackMangaButton } from '@/modules/manga/components/TrackMangaButton.tsx';
@@ -44,7 +39,8 @@ import { useLocalStorage } from '@/modules/core/hooks/useStorage.tsx';
 import { useResizeObserver } from '@/modules/core/hooks/useResizeObserver.tsx';
 import { useMetadataServerSettings } from '@/modules/settings/services/ServerSettingsMetadata.ts';
 import { shouldForwardProp } from '@/modules/core/utils/ShouldForwardProp.ts';
-import { MANGA_COVER_ASPECT_RATIO } from '@/modules/manga/Manga.constants.ts';
+import { MANGA_COVER_ASPECT_RATIO, statusToTranslationKey } from '@/modules/manga/Manga.constants.ts';
+import { MangaThumbnailInfo, MangaTrackRecordInfo } from '@/modules/manga/Manga.types.ts';
 
 const DetailsWrapper = styled('div')(({ theme }) => ({
     display: 'flex',

src/modules/manga/components/TrackMangaButton.tsx

@@ -19,7 +19,8 @@ import { Trackers } from '@/modules/tracker/services/Trackers.ts';
 import { CustomIconButton } from '@/modules/core/components/buttons/CustomIconButton.tsx';
 import { GetTrackersSettingsQuery, MangaType } from '@/lib/graphql/generated/graphql.ts';
 import { GET_TRACKERS_SETTINGS } from '@/lib/graphql/queries/TrackerQuery.ts';
-import { MangaTrackRecordInfo } from '@/modules/manga/services/Mangas.ts';
+
+import { MangaTrackRecordInfo } from '@/modules/manga/Manga.types.ts';
 
 export const TrackMangaButton = ({ manga }: { manga: MangaTrackRecordInfo & Pick<MangaType, 'title'> }) => {
     const { t } = useTranslation();

src/modules/manga/services/Mangas.ts

@@ -17,10 +17,6 @@ import {
     GetMangaToMigrateQuery,
     GetMangaToMigrateToFetchMutation,
     MangaBaseFieldsFragment,
-    MangaReaderFieldsFragment,
-    MangaStatus,
-    MangaType,
-    TrackRecordType,
     UpdateMangaCategoriesPatchInput,
 } from '@/lib/graphql/generated/graphql.ts';
 import { Chapters } from '@/modules/chapter/services/Chapters.ts';
@@ -28,117 +24,16 @@ import { makeToast } from '@/modules/core/utils/Toast.ts';
 import { getMetadataServerSettings } from '@/modules/settings/services/ServerSettingsMetadata.ts';
 import { GET_MANGAS_BASE } from '@/lib/graphql/queries/MangaQuery.ts';
 import { MANGA_BASE_FIELDS } from '@/lib/graphql/fragments/MangaFragments.ts';
-import { TranslationKey } from '@/Base.types.ts';
 import { MetadataMigrationSettings } from '@/modules/migration/Migration.types.ts';
-
-export type MangaAction =
-    | 'download'
-    | 'delete'
-    | 'mark_as_read'
-    | 'mark_as_unread'
-    | 'remove_from_library'
-    | 'change_categories'
-    | 'migrate'
-    | 'track';
-
-export const statusToTranslationKey: Record<MangaStatus, TranslationKey> = {
-    [MangaStatus.Cancelled]: 'manga.status.cancelled',
-    [MangaStatus.Completed]: 'manga.status.completed',
-    [MangaStatus.Licensed]: 'manga.status.licensed',
-    [MangaStatus.Ongoing]: 'manga.status.ongoing',
-    [MangaStatus.OnHiatus]: 'manga.status.hiatus',
-    [MangaStatus.PublishingFinished]: 'manga.status.publishing_finished',
-    [MangaStatus.Unknown]: 'manga.status.unknown',
-};
-
-export const actionToTranslationKey: {
-    [key in MangaAction]: {
-        action: {
-            single: TranslationKey;
-            selected: TranslationKey;
-        };
-        success: TranslationKey;
-        error: TranslationKey;
-    };
-} = {
-    download: {
-        action: {
-            single: 'chapter.action.download.add.label.action',
-            selected: 'chapter.action.download.add.button.selected',
-        },
-        success: 'chapter.action.download.add.label.success',
-        error: 'chapter.action.download.add.label.error',
-    },
-    delete: {
-        action: {
-            single: 'chapter.action.download.delete.label.action',
-            selected: 'chapter.action.download.delete.button.selected',
-        },
-        success: 'chapter.action.download.delete.label.success',
-        error: 'chapter.action.download.delete.label.error',
-    },
-    mark_as_read: {
-        action: {
-            single: 'chapter.action.mark_as_read.add.label.action.current',
-            selected: 'chapter.action.mark_as_read.add.button.selected',
-        },
-        success: 'chapter.action.mark_as_read.add.label.success',
-        error: 'chapter.action.mark_as_read.add.label.error',
-    },
-    mark_as_unread: {
-        action: {
-            single: 'chapter.action.mark_as_read.remove.label.action',
-            selected: 'chapter.action.mark_as_read.remove.button.selected',
-        },
-        success: 'chapter.action.mark_as_read.remove.label.success',
-        error: 'chapter.action.mark_as_read.remove.label.error',
-    },
-    remove_from_library: {
-        action: {
-            single: 'manga.action.library.remove.label.action',
-            selected: 'manga.action.library.remove.button.selected',
-        },
-        success: 'manga.action.library.remove.label.success',
-        error: 'manga.action.library.remove.label.error',
-    },
-    change_categories: {
-        action: {
-            single: 'manga.action.category.label.action',
-            selected: 'manga.action.category.button.selected',
-        },
-        success: 'manga.action.category.label.success',
-        error: 'manga.action.category.label.error',
-    },
-    migrate: {
-        action: {
-            single: 'global.button.migrate',
-            selected: 'global.button.migrate', // not supported
-        },
-        success: 'manga.action.migrate.label.success',
-        error: 'manga.action.migrate.label.error',
-    },
-    track: {
-        action: {
-            single: 'manga.action.track.add.label.action',
-            selected: 'manga.action.track.add.label.action', // not supported
-        },
-        success: 'manga.action.track.add.label.success',
-        error: 'manga.action.track.add.label.error',
-    },
-};
-
-export type TMangaReader = MangaReaderFieldsFragment;
-
-export type MangaIdInfo = Pick<MangaType, 'id'>;
-export type MangaChapterCountInfo = { chapters: Pick<MangaType['chapters'], 'totalCount'> };
-export type MangaDownloadInfo = Pick<MangaType, 'downloadCount'> & MangaChapterCountInfo;
-export type MangaUnreadInfo = Pick<MangaType, 'unreadCount'> & MangaChapterCountInfo;
-export type MangaThumbnailInfo = Pick<MangaType, 'thumbnailUrl' | 'thumbnailUrlLastFetched'>;
-export type MangaTrackRecordInfo = MangaIdInfo & {
-    trackRecords: { nodes: Pick<TrackRecordType, 'id' | 'trackerId'>[] };
-};
-
-export type MigrateMode = 'copy' | 'migrate';
+import {
+    MangaAction,
+    MangaDownloadInfo,
+    MangaIdInfo,
+    MangaThumbnailInfo,
+    MangaUnreadInfo,
+    MigrateMode,
+} from '@/modules/manga/Manga.types.ts';
+import { actionToTranslationKey } from '@/modules/manga/Manga.constants.ts';
 
 type MangaToMigrate = NonNullable<GetMangaToMigrateQuery['manga']>;
 type MangaToMigrateTo = NonNullable<GetMangaToMigrateToFetchMutation['fetchManga']>['manga'];