From f0fc31ceacecec7ebaa652fe368e403ecde7aff9 Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Sun, 3 Mar 2024 23:07:12 +0100 Subject: [PATCH] Fix/spinner image not able to be opened in new tab or saved (#635) After the object url has been revoked the image can't be used anymore --- src/components/util/SpinnerImage.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/components/util/SpinnerImage.tsx b/src/components/util/SpinnerImage.tsx index e1c31388..a36269b3 100644 --- a/src/components/util/SpinnerImage.tsx +++ b/src/components/util/SpinnerImage.tsx @@ -48,6 +48,7 @@ export const SpinnerImage = forwardRef((props: IProps, imgRef: ForwardedRef { + let tmpImageSourceUrl: string; const imageRequest = requestManager.requestImage(src); const fetchImage = async () => { @@ -57,6 +58,7 @@ export const SpinnerImage = forwardRef((props: IProps, imgRef: ForwardedRef { + if (tmpImageSourceUrl) { + URL.revokeObjectURL(tmpImageSourceUrl); + } imageRequest.abortRequest(new Error('Component was unmounted')); }; }, [imgLoadRetryKey]); @@ -116,7 +121,6 @@ export const SpinnerImage = forwardRef((props: IProps, imgRef: ForwardedRef URL.revokeObjectURL(imageSourceUrl)} alt={alt} draggable={false} />