Cleanup deprecated metadata after migration

- delete deprecated metadata
- save applied migration id per metadata holder

src/modules/source/components/SourceGridLayout.tsx

@@ -6,9 +6,9 @@
  * file, You can obtain one at https://mozilla.org/MPL/2.0/.
  */
 
-import { GridLayout } from '@/modules/library/contexts/LibraryOptionsContext.tsx';
 import { GridLayouts } from '@/modules/core/components/GridLayouts.tsx';
 import { useLocalStorage } from '@/modules/core/hooks/useStorage.tsx';
+import { GridLayout } from '@/modules/core/Core.types.ts';
 
 export function SourceGridLayout() {
     const [sourceGridLayout, setSourceGridLayout] = useLocalStorage('source-grid-layout', GridLayout.Compact);

src/modules/source/screens/SourceMangas.tsx

@@ -25,7 +25,6 @@ import {
     AbortableApolloUseMutationPaginatedResponse,
     SPECIAL_ED_SOURCES,
 } from '@/lib/requests/RequestManager.ts';
-import { GridLayout } from '@/modules/library/contexts/LibraryOptionsContext.tsx';
 import { SourceGridLayout } from '@/modules/source/components/SourceGridLayout.tsx';
 import { AppbarSearch } from '@/modules/core/components/AppbarSearch.tsx';
 import { SourceOptions } from '@/modules/source/components/SourceOptions.tsx';
@@ -35,13 +34,14 @@ import {
     GetSourceBrowseQueryVariables,
     GetSourceMangasFetchMutation,
     GetSourceMangasFetchMutationVariables,
+    SourceType,
 } from '@/lib/graphql/generated/graphql.ts';
 import { NavBarContext } from '@/modules/navigation-bar/contexts/NavbarContext.tsx';
 import { useMetadataServerSettings } from '@/modules/settings/services/ServerSettingsMetadata.ts';
 import { useLocalStorage, useSessionStorage } from '@/modules/core/hooks/useStorage.tsx';
 import { AppStorage } from '@/lib/storage/AppStorage.ts';
 import { getGridSnapshotKey } from '@/modules/manga/components/MangaGrid.tsx';
-import { createUpdateSourceMetadata, getSourceMetadata } from '@/modules/source/services/SourceMetadata.ts';
+import { createUpdateSourceMetadata, useGetSourceMetadata } from '@/modules/source/services/SourceMetadata.ts';
 import { makeToast } from '@/modules/core/utils/Toast.ts';
 import { GET_SOURCE_BROWSE } from '@/lib/graphql/queries/SourceQuery.ts';
 import { TranslationKey } from '@/Base.types.ts';
@@ -50,6 +50,9 @@ import { defaultPromiseErrorHandler } from '@/lib/DefaultPromiseErrorHandler.ts'
 import { EmptyView } from '@/modules/core/components/placeholder/EmptyView.tsx';
 import { EmptyViewAbsoluteCentered } from '@/modules/core/components/placeholder/EmptyViewAbsoluteCentered.tsx';
 import { MangaIdInfo } from '@/modules/manga/Manga.types.ts';
+import { GridLayout } from '@/modules/core/Core.types.ts';
+
+const DEFAULT_SOURCE: Pick<SourceType, 'id'> = { id: '-1' };
 
 const ContentTypeMenu = styled('div')(({ theme }) => ({
     display: 'flex',
@@ -285,8 +288,8 @@ export function SourceMangas() {
     const source = sourceData?.source;
 
     const filters = source?.filters ?? [];
-    const { savedSearches = {} } = useMemo(() => getSourceMetadata(source), [source, source?.meta]);
-    const updateSourceMetadata = createUpdateSourceMetadata<'savedSearches'>(source ?? { id: sourceId }, () =>
+    const { savedSearches = {} } = useGetSourceMetadata(source ?? DEFAULT_SOURCE);
+    const updateSourceMetadata = createUpdateSourceMetadata<'savedSearches'>(source ?? { id: '-1' }, () =>
         makeToast(t('global.error.label.failed_to_save_changes'), 'error'),
     );
 

src/modules/source/services/SourceMetadata.ts

@@ -6,6 +6,7 @@
  * file, You can obtain one at https://mozilla.org/MPL/2.0/.
  */
 
+import { useEffect, useMemo } from 'react';
 import { jsonSaveParse } from '@/lib/HelperFunctions.ts';
 import { requestUpdateSourceMetadata } from '@/modules/metadata/services/MetadataUpdater.ts';
 import { defaultPromiseErrorHandler } from '@/lib/DefaultPromiseErrorHandler.ts';
@@ -20,6 +21,10 @@ import {
     Metadata,
 } from '@/modules/metadata/Metadata.types.ts';
 
+const DEFAULT_SOURCE_METADATA: ISourceMetadata = {
+    savedSearches: undefined,
+};
+
 const convertAppMetadataToGqlMetadata = (
     metadata: Partial<ISourceMetadata>,
 ): Metadata<string, AllowedMetadataValueTypes> => ({
@@ -27,18 +32,35 @@ const convertAppMetadataToGqlMetadata = (
     savedSearches: metadata.savedSearches ? JSON.stringify(metadata.savedSearches) : undefined,
 });
 
-export const convertGqlMetadataToAppMetadata = (
+const convertGqlMetadataToAppMetadata = (
     metadata: Partial<Metadata<AppMetadataKeys, AllowedMetadataValueTypes>>,
 ): ISourceMetadata => ({
     ...(metadata as unknown as ISourceMetadata),
     savedSearches: jsonSaveParse<ISourceMetadata['savedSearches']>(metadata.savedSearches as string) ?? undefined,
 });
 
-export const getSourceMetadata = ({ meta }: GqlMetaHolder = {}, applyMetadataMigration?: boolean): ISourceMetadata =>
+const getMetadata = (
+    metaHolder: Pick<SourceType, 'id'> & GqlMetaHolder,
+    useEffectFn?: typeof useEffect,
+): ISourceMetadata =>
     convertGqlMetadataToAppMetadata(
-        getMetadataFrom({ meta: convertFromGqlMeta(meta) }, { savedSearches: undefined }, applyMetadataMigration),
+        getMetadataFrom(
+            'source',
+            { ...metaHolder, meta: convertFromGqlMeta(metaHolder.meta) },
+            convertAppMetadataToGqlMetadata(DEFAULT_SOURCE_METADATA),
+            true,
+            useEffectFn,
+        ),
     );
 
+export const getSourceMetadata = (metaHolder: Pick<SourceType, 'id'> & GqlMetaHolder): ISourceMetadata =>
+    getMetadata(metaHolder);
+
+export const useGetSourceMetadata = (metaHolder: Pick<SourceType, 'id'> & GqlMetaHolder): ISourceMetadata => {
+    const metadata = getMetadata(metaHolder, useEffect);
+    return useMemo(() => metadata, [metaHolder]);
+};
+
 export const updateSourceMetadata = async <
     MetadataKeys extends SourceMetadataKeys = SourceMetadataKeys,
     MetadataKey extends MetadataKeys = MetadataKeys,