From e707e7b7da66788887702b097b4f4c3537ed5ecf Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Sun, 6 Oct 2024 16:20:50 +0200 Subject: [PATCH] Handle track search error Apollo fails to handle changes in the options context (e.g. abort controller) which causes the request to infinitely re-trigger on errors. By not adding an abort controller, this gets prevented, however, it prevents the search to be aborted on e.g. changing the search string --- src/modules/tracker/components/TrackerSearch.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/tracker/components/TrackerSearch.tsx b/src/modules/tracker/components/TrackerSearch.tsx index 721cff14..10d1c3bd 100644 --- a/src/modules/tracker/components/TrackerSearch.tsx +++ b/src/modules/tracker/components/TrackerSearch.tsx @@ -53,7 +53,9 @@ export const TrackerSearch = ({ const [selectedTrackerRemoteId, setSelectedTrackerRemoteId] = useState(trackedId); - const trackerSearch = requestManager.useTrackerSearch(tracker.id, searchString, { addAbortSignal: true }); + const trackerSearch = requestManager.useTrackerSearch(tracker.id, searchString, { + notifyOnNetworkStatusChange: true, + }); const searchResults = trackerSearch.data?.searchTracker.trackSearches ?? []; const hasResults = !!searchResults.length;