Allow editing SOCKS and basic auth settings while disabled (#726)

In case these settings were disabled, the other dependent settings were not editable.
This prevented them from being set up as needed before enabling them
This commit is contained in:
schroda
2024-04-10 01:22:58 +02:00
committed by GitHub
parent 6c43e974e2
commit d74bd2f80d

View File

@@ -159,31 +159,26 @@ export const ServerSettings = () => {
[5, { text: '5' }], [5, { text: '5' }],
]} ]}
handleChange={(socksProxyVersion) => updateSetting('socksProxyVersion', socksProxyVersion)} handleChange={(socksProxyVersion) => updateSetting('socksProxyVersion', socksProxyVersion)}
disabled={!serverSettings?.socksProxyEnabled}
/> />
<TextSetting <TextSetting
settingName={t('settings.server.socks_proxy.label.host')} settingName={t('settings.server.socks_proxy.label.host')}
value={serverSettings?.socksProxyHost} value={serverSettings?.socksProxyHost}
handleChange={(proxyHost) => updateSetting('socksProxyHost', proxyHost)} handleChange={(proxyHost) => updateSetting('socksProxyHost', proxyHost)}
disabled={!serverSettings?.socksProxyEnabled}
/> />
<TextSetting <TextSetting
settingName={t('settings.server.socks_proxy.label.port')} settingName={t('settings.server.socks_proxy.label.port')}
value={serverSettings?.socksProxyPort} value={serverSettings?.socksProxyPort}
handleChange={(proxyPort) => updateSetting('socksProxyPort', proxyPort)} handleChange={(proxyPort) => updateSetting('socksProxyPort', proxyPort)}
disabled={!serverSettings?.socksProxyEnabled}
/> />
<TextSetting <TextSetting
settingName={t('settings.server.socks_proxy.label.username')} settingName={t('settings.server.socks_proxy.label.username')}
value={serverSettings?.socksProxyUsername} value={serverSettings?.socksProxyUsername}
handleChange={(proxyUsername) => updateSetting('socksProxyUsername', proxyUsername)} handleChange={(proxyUsername) => updateSetting('socksProxyUsername', proxyUsername)}
disabled={!serverSettings?.socksProxyEnabled}
/> />
<TextSetting <TextSetting
settingName={t('settings.server.socks_proxy.label.password')} settingName={t('settings.server.socks_proxy.label.password')}
value={serverSettings?.socksProxyPassword} value={serverSettings?.socksProxyPassword}
handleChange={(proxyPassword) => updateSetting('socksProxyPassword', proxyPassword)} handleChange={(proxyPassword) => updateSetting('socksProxyPassword', proxyPassword)}
disabled={!serverSettings?.socksProxyEnabled}
isPassword isPassword
/> />
</List> </List>
@@ -206,14 +201,12 @@ export const ServerSettings = () => {
settingName={t('settings.server.auth.basic.label.username')} settingName={t('settings.server.auth.basic.label.username')}
value={serverSettings?.basicAuthUsername} value={serverSettings?.basicAuthUsername}
handleChange={(authUsername) => updateSetting('basicAuthUsername', authUsername)} handleChange={(authUsername) => updateSetting('basicAuthUsername', authUsername)}
disabled={!serverSettings?.basicAuthEnabled}
/> />
<TextSetting <TextSetting
settingName={t('settings.server.auth.basic.label.password')} settingName={t('settings.server.auth.basic.label.password')}
value={serverSettings?.basicAuthPassword} value={serverSettings?.basicAuthPassword}
isPassword isPassword
handleChange={(authPassword) => updateSetting('basicAuthPassword', authPassword)} handleChange={(authPassword) => updateSetting('basicAuthPassword', authPassword)}
disabled={!serverSettings?.basicAuthEnabled}
/> />
</List> </List>
<List <List