From cc4ab2e0dd5325ea6c83bbdbbbaf39be20dc5e41 Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Mon, 21 Jul 2025 23:01:07 +0200 Subject: [PATCH] Remove unused args in "createUpdateReaderPageLoadState" --- src/modules/reader/components/viewer/ReaderChapterViewer.tsx | 4 ---- src/modules/reader/utils/Reader.utils.ts | 2 -- 2 files changed, 6 deletions(-) diff --git a/src/modules/reader/components/viewer/ReaderChapterViewer.tsx b/src/modules/reader/components/viewer/ReaderChapterViewer.tsx index 9cf5ab32..53b4b8a1 100644 --- a/src/modules/reader/components/viewer/ReaderChapterViewer.tsx +++ b/src/modules/reader/components/viewer/ReaderChapterViewer.tsx @@ -213,9 +213,7 @@ const BaseReaderChapterViewer = ({ () => createUpdateReaderPageLoadState( actualPages, - pagesToSpreadState, setPagesToSpreadState, - pageLoadStates, (value) => { if (isCurrentChapterRef.current) { setContextPageLoadStates(value); @@ -225,8 +223,6 @@ const BaseReaderChapterViewer = ({ }, readingMode, ), - // do not add "pagesToSpreadState" and "pageLoadStates" as a dependency, otherwise, every page gets re-rendered - // when they change which impacts the performance massively (depending on the total page count) [actualPages, readingMode], ); diff --git a/src/modules/reader/utils/Reader.utils.ts b/src/modules/reader/utils/Reader.utils.ts index 5ed837ab..f7cb7d16 100644 --- a/src/modules/reader/utils/Reader.utils.ts +++ b/src/modules/reader/utils/Reader.utils.ts @@ -132,9 +132,7 @@ export const getChapterIdsForDownloadAhead = ( export const createUpdateReaderPageLoadState = ( actualPages: ReaderStatePages['pages'], - pagesToSpreadState: ReaderPageSpreadState[], setPagesToSpreadState: React.Dispatch>, - pageLoadStates: ReaderStatePages['pageLoadStates'], setPageLoadStates: ReaderStatePages['setPageLoadStates'], readingMode: ReadingMode, ) =>