Add missing error message on settings change error

This commit is contained in:
schroda
2024-09-26 12:51:46 +02:00
parent 314ad39ee0
commit c72cf9a0ab
5 changed files with 18 additions and 6 deletions

View File

@@ -39,7 +39,7 @@ export const DownloadAheadSetting = ({
const updateSetting = (value: MetadataDownloadSettings['downloadAheadLimit']) => { const updateSetting = (value: MetadataDownloadSettings['downloadAheadLimit']) => {
persistDownloadAheadLimit(value === 0 ? currentDownloadAheadLimit : value); persistDownloadAheadLimit(value === 0 ? currentDownloadAheadLimit : value);
updateMetadataServerSettings('downloadAheadLimit', value).catch(() => updateMetadataServerSettings('downloadAheadLimit', value).catch(() =>
makeToast(t('search.error.label.failed_to_save_settings'), 'warning'), makeToast(t('global.error.label.failed_to_save_changes'), 'error'),
); );
}; };

View File

@@ -16,6 +16,7 @@ import { requestManager } from '@/lib/requests/RequestManager.ts';
import { NumberSetting } from '@/components/settings/NumberSetting.tsx'; import { NumberSetting } from '@/components/settings/NumberSetting.tsx';
import { getPersistedServerSetting, usePersistedValue } from '@/util/usePersistedValue.tsx'; import { getPersistedServerSetting, usePersistedValue } from '@/util/usePersistedValue.tsx';
import { ServerSettings } from '@/typings.ts'; import { ServerSettings } from '@/typings.ts';
import { makeToast } from '@/components/util/Toast.tsx';
const DEFAULT_VALUE = 23; const DEFAULT_VALUE = 23;
const MIN_VALUE = 1; const MIN_VALUE = 1;
@@ -44,7 +45,9 @@ export const WebUIUpdateIntervalSetting = ({
persistUpdateCheckInterval( persistUpdateCheckInterval(
webUIUpdateCheckInterval === 0 ? currentUpdateCheckInterval : webUIUpdateCheckInterval, webUIUpdateCheckInterval === 0 ? currentUpdateCheckInterval : webUIUpdateCheckInterval,
); );
mutateSettings({ variables: { input: { settings: { webUIUpdateCheckInterval } } } }); mutateSettings({ variables: { input: { settings: { webUIUpdateCheckInterval } } } }).catch(() =>
makeToast(t('global.error.label.failed_to_save_changes'), 'error'),
);
}, },
[currentUpdateCheckInterval], [currentUpdateCheckInterval],
); );

View File

@@ -100,7 +100,9 @@ export function Backup() {
setting: Setting, setting: Setting,
value: BackupSettingsType[Setting], value: BackupSettingsType[Setting],
) => { ) => {
mutateSettings({ variables: { input: { settings: { [setting]: value } } } }); mutateSettings({ variables: { input: { settings: { [setting]: value } } } }).catch(() =>
makeToast(t('global.error.label.failed_to_save_changes'), 'error'),
);
}; };
useEffect(() => { useEffect(() => {

View File

@@ -26,6 +26,7 @@ import {
import { LoadingPlaceholder } from '@/components/util/LoadingPlaceholder.tsx'; import { LoadingPlaceholder } from '@/components/util/LoadingPlaceholder.tsx';
import { EmptyViewAbsoluteCentered } from '@/components/util/EmptyViewAbsoluteCentered.tsx'; import { EmptyViewAbsoluteCentered } from '@/components/util/EmptyViewAbsoluteCentered.tsx';
import { defaultPromiseErrorHandler } from '@/util/defaultPromiseErrorHandler.ts'; import { defaultPromiseErrorHandler } from '@/util/defaultPromiseErrorHandler.ts';
import { makeToast } from '@/components/util/Toast.tsx';
type ExtensionsSettings = Pick<GqlServerSettings, 'maxSourcesInParallel' | 'localSourcePath' | 'extensionRepos'>; type ExtensionsSettings = Pick<GqlServerSettings, 'maxSourcesInParallel' | 'localSourcePath' | 'extensionRepos'>;
@@ -55,13 +56,17 @@ export const BrowseSettings = () => {
setting: Setting, setting: Setting,
value: ExtensionsSettings[Setting], value: ExtensionsSettings[Setting],
) => { ) => {
mutateSettings({ variables: { input: { settings: { [setting]: value } } } }); mutateSettings({ variables: { input: { settings: { [setting]: value } } } }).catch(() =>
makeToast(t('global.error.label.failed_to_save_changes'), 'error'),
);
}; };
const { const {
settings: { hideLibraryEntries }, settings: { hideLibraryEntries },
} = useMetadataServerSettings(); } = useMetadataServerSettings();
const updateMetadataServerSettings = createUpdateMetadataServerSettings<keyof MetadataBrowseSettings>(); const updateMetadataServerSettings = createUpdateMetadataServerSettings<keyof MetadataBrowseSettings>(() =>
makeToast(t('global.error.label.failed_to_save_changes'), 'error'),
);
if (loading) { if (loading) {
return <LoadingPlaceholder />; return <LoadingPlaceholder />;

View File

@@ -137,7 +137,9 @@ export const ServerSettings = () => {
setting: Setting, setting: Setting,
value: ServerSettingsType[Setting], value: ServerSettingsType[Setting],
) => { ) => {
mutateSettings({ variables: { input: { settings: { [setting]: value } } } }); mutateSettings({ variables: { input: { settings: { [setting]: value } } } }).catch(() =>
makeToast(t('global.error.label.failed_to_save_changes'), 'error'),
);
}; };
const localSettings = useMemo( const localSettings = useMemo(