From b67c9c4e44b95c6409124a8e07fef6590a809405 Mon Sep 17 00:00:00 2001
From: schroda <50052685+schroda@users.noreply.github.com>
Date: Thu, 23 Jan 2025 20:36:19 +0100
Subject: [PATCH] Fix reader chapter transition page positioning in double page
 mode

Regression 649a17c2aea52cc01f644d831c493b99fee966fc
---
 .../components/viewer/pager/BasePager.tsx     | 20 +++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/modules/reader/components/viewer/pager/BasePager.tsx b/src/modules/reader/components/viewer/pager/BasePager.tsx
index 0fbe68d1..c3737ce5 100644
--- a/src/modules/reader/components/viewer/pager/BasePager.tsx
+++ b/src/modules/reader/components/viewer/pager/BasePager.tsx
@@ -9,10 +9,12 @@
 import { memo, ReactNode, useCallback, useEffect, useMemo, useRef } from 'react';
 import Box, { BoxProps } from '@mui/material/Box';
 import { ReaderService } from '@/modules/reader/services/ReaderService.ts';
-import { getPageIndexesToLoad } from '@/modules/reader/utils/ReaderPager.utils.tsx';
+import { getPageIndexesToLoad, isATransitionPageVisible } from '@/modules/reader/utils/ReaderPager.utils.tsx';
 import { ReaderStatePages } from '@/modules/reader/types/ReaderProgressBar.types.ts';
 import { IReaderSettings, ReaderPagerProps, ReaderTransitionPageMode } from '@/modules/reader/types/Reader.types.ts';
 import { withPropsFrom } from '@/modules/core/hoc/withPropsFrom.tsx';
+import { applyStyles } from '@/modules/core/utils/ApplyStyles.ts';
+import { isContinuousReadingMode } from '@/modules/reader/utils/ReaderSettings.utils.tsx';
 
 const BaseBasePager = ({
     currentPageIndex,
@@ -62,8 +64,22 @@ const BaseBasePager = ({
         <Box
             {...slots?.boxProps}
             sx={[
-                { width: 'fit-content', height: 'fit-content' },
+                {
+                    width: 'fit-content',
+                    height: 'fit-content',
+                },
                 ...(Array.isArray(slots?.boxProps?.sx) ? (slots?.boxProps?.sx ?? []) : [slots?.boxProps?.sx]),
+                // hide pager, without actually unmounting it to prevent re-renders, while a chapter transition page is taking up the full screen
+                applyStyles(
+                    !isContinuousReadingMode(readingMode) && isATransitionPageVisible(transitionPageMode, readingMode),
+                    {
+                        visibility: 'hidden',
+                        width: 0,
+                        height: 0,
+                        m: 0,
+                        p: 0,
+                    },
+                ),
             ]}
         >
             {pages.map((page, pagesIndex) =>