From b5a0ec737150212c8af5b4ede997946929737c15 Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Thu, 2 Jan 2025 21:48:23 +0100 Subject: [PATCH] Ignore reading direction for vertical progress bar The page change handling of the progress bar was inverted while RTL was the set readers reading direction. However, this is only relevant for the horizontal progress bar --- .../components/overlay/progress-bar/ReaderProgressBar.tsx | 4 ---- .../overlay/progress-bar/variants/MobileReaderProgressBar.tsx | 1 + .../progress-bar/variants/StandardReaderProgressBar.tsx | 1 + 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/modules/reader/components/overlay/progress-bar/ReaderProgressBar.tsx b/src/modules/reader/components/overlay/progress-bar/ReaderProgressBar.tsx index e2144ef0..5ab53a1f 100644 --- a/src/modules/reader/components/overlay/progress-bar/ReaderProgressBar.tsx +++ b/src/modules/reader/components/overlay/progress-bar/ReaderProgressBar.tsx @@ -247,9 +247,6 @@ export const ReaderProgressBar = withPropsFrom( [ useReaderProgressBarContext, () => ({ openPage: ReaderControls.useOpenPage() }), - () => ({ - direction: ReaderService.useGetThemeDirection(), - }), userReaderStatePagesContext, ReaderService.useSettingsWithoutDefaultFlag, ], @@ -257,7 +254,6 @@ export const ReaderProgressBar = withPropsFrom( 'isDragging', 'setIsDragging', 'openPage', - 'direction', 'pages', 'pageLoadStates', 'totalPages', diff --git a/src/modules/reader/components/overlay/progress-bar/variants/MobileReaderProgressBar.tsx b/src/modules/reader/components/overlay/progress-bar/variants/MobileReaderProgressBar.tsx index d871bf47..149c2b06 100644 --- a/src/modules/reader/components/overlay/progress-bar/variants/MobileReaderProgressBar.tsx +++ b/src/modules/reader/components/overlay/progress-bar/variants/MobileReaderProgressBar.tsx @@ -182,6 +182,7 @@ const BaseMobileReaderProgressBar = ({ )}