From b1dc13cd30bfdc374123019a9fc51c07e5824633 Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Tue, 28 Mar 2023 23:14:03 +0200 Subject: [PATCH] Update browser and nav bar title on language change (#275) --- src/screens/DownloadQueue.tsx | 2 +- src/screens/Extensions.tsx | 2 +- src/screens/Library.tsx | 2 +- src/screens/Manga.tsx | 2 +- src/screens/Reader.tsx | 2 +- src/screens/SearchAll.tsx | 4 ++-- src/screens/Settings.tsx | 2 +- src/screens/SourceConfigure.tsx | 2 +- src/screens/SourceMangas.tsx | 2 +- src/screens/Sources.tsx | 2 +- src/screens/Updates.tsx | 2 +- src/screens/settings/About.tsx | 2 +- src/screens/settings/Backup.tsx | 2 +- src/screens/settings/Categories.tsx | 2 +- src/screens/settings/DefaultReaderSettings.tsx | 2 +- 15 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/screens/DownloadQueue.tsx b/src/screens/DownloadQueue.tsx index 3fe31bf8..7d09b37b 100644 --- a/src/screens/DownloadQueue.tsx +++ b/src/screens/DownloadQueue.tsx @@ -53,7 +53,7 @@ const DownloadQueue: React.FC = () => { useEffect(() => { setTitle(t('download.queue.title')); setAction(null); - }, []); + }, [t]); // eslint-disable-next-line @typescript-eslint/no-unused-vars const onDragEnd = (result: DropResult) => {}; diff --git a/src/screens/Extensions.tsx b/src/screens/Extensions.tsx index 7a1b6579..dcf6b262 100644 --- a/src/screens/Extensions.tsx +++ b/src/screens/Extensions.tsx @@ -88,7 +88,7 @@ export default function MangaExtensions() { , ); - }, [shownLangs]); + }, [t, shownLangs]); const { data: allExtensions, mutate, loading } = useQuery('/api/v1/extension/list'); diff --git a/src/screens/Library.tsx b/src/screens/Library.tsx index 251f17fa..5d433026 100644 --- a/src/screens/Library.tsx +++ b/src/screens/Library.tsx @@ -53,7 +53,7 @@ export default function Library() { setTitle(''); setAction(null); }; - }, []); + }, [t]); const handleTabChange = (newTab: number) => { setTabSearchParam(newTab === 0 ? undefined : newTab); diff --git a/src/screens/Manga.tsx b/src/screens/Manga.tsx index fa191ca0..1de3a762 100644 --- a/src/screens/Manga.tsx +++ b/src/screens/Manga.tsx @@ -62,7 +62,7 @@ const Manga: React.FC = () => { useEffect(() => { setTitle(manga?.title ?? t('manga.title')); - }, [manga?.title]); + }, [t, manga?.title]); if (error && !manga) { return ; diff --git a/src/screens/Reader.tsx b/src/screens/Reader.tsx index 3c31706f..7e0ad86c 100644 --- a/src/screens/Reader.tsx +++ b/src/screens/Reader.tsx @@ -99,7 +99,7 @@ export default function Reader() { } else { setTitle(`${manga.title}: ${(chapter as IChapter).name}`); } - }, [manga, chapter]); + }, [t, manga, chapter]); useEffect(() => { if (!areDefaultSettingsLoading && !isMangaLoading) { diff --git a/src/screens/SearchAll.tsx b/src/screens/SearchAll.tsx index 60be2268..4b9264a9 100644 --- a/src/screens/SearchAll.tsx +++ b/src/screens/SearchAll.tsx @@ -58,7 +58,7 @@ const SearchAll: React.FC = () => { useEffect(() => { setTitle(t('search.title.global_search')); setAction(); - }, []); + }, [t]); useEffect(() => { client @@ -161,7 +161,7 @@ const SearchAll: React.FC = () => { /> , ); - }, [shownLangs, sources]); + }, [t, shownLangs, sources]); if (query) { return ( diff --git a/src/screens/Settings.tsx b/src/screens/Settings.tsx index adf4824c..e9734d11 100644 --- a/src/screens/Settings.tsx +++ b/src/screens/Settings.tsx @@ -47,7 +47,7 @@ export default function Settings() { useEffect(() => { setTitle(t('settings.title')); setAction(null); - }, []); + }, [t]); const { darkTheme, setDarkTheme } = useContext(DarkTheme); const [serverAddress, setServerAddress] = useLocalStorage('serverBaseURL', ''); diff --git a/src/screens/SourceConfigure.tsx b/src/screens/SourceConfigure.tsx index ea4d40ab..299f408e 100644 --- a/src/screens/SourceConfigure.tsx +++ b/src/screens/SourceConfigure.tsx @@ -42,7 +42,7 @@ export default function SourceConfigure() { useEffect(() => { setTitle(t('source.configuration.title')); setAction(null); - }, []); + }, [t]); const { sourceId } = useParams<{ sourceId: string }>(); const { data: sourcePreferences = [], mutate } = useQuery( diff --git a/src/screens/SourceMangas.tsx b/src/screens/SourceMangas.tsx index b5916bb1..e8afffe1 100644 --- a/src/screens/SourceMangas.tsx +++ b/src/screens/SourceMangas.tsx @@ -61,7 +61,7 @@ export default function SourceMangas({ popular }: { popular: boolean }) { useEffect(() => { setTitle(t('source.title')); // title is later set after a fetch but we set it here once - }, []); + }, [t]); useEffect(() => { client diff --git a/src/screens/Sources.tsx b/src/screens/Sources.tsx index 5bf91f5e..cceded62 100644 --- a/src/screens/Sources.tsx +++ b/src/screens/Sources.tsx @@ -86,7 +86,7 @@ export default function Sources() { /> , ); - }, [shownLangs, sources]); + }, [t, shownLangs, sources]); if (loading) return ; diff --git a/src/screens/Updates.tsx b/src/screens/Updates.tsx index 97825935..323438b0 100644 --- a/src/screens/Updates.tsx +++ b/src/screens/Updates.tsx @@ -103,7 +103,7 @@ const Updates: React.FC = () => { setTitle(t('updates.title')); setAction(null); - }, []); + }, [t]); useEffect(() => { if (hasNextPage) { diff --git a/src/screens/settings/About.tsx b/src/screens/settings/About.tsx index 835e3302..2de77f90 100644 --- a/src/screens/settings/About.tsx +++ b/src/screens/settings/About.tsx @@ -16,7 +16,7 @@ export default function About() { useEffect(() => { setTitle(t('settings.about.title')); setAction(null); - }, []); + }, [t]); const { data: about } = useQuery('/api/v1/settings/about'); diff --git a/src/screens/settings/Backup.tsx b/src/screens/settings/Backup.tsx index cd560a5f..a9cae24a 100644 --- a/src/screens/settings/Backup.tsx +++ b/src/screens/settings/Backup.tsx @@ -22,7 +22,7 @@ export default function Backup() { useEffect(() => { setTitle(t('settings.backup.title')); setAction(null); - }, []); + }, [t]); const { baseURL } = client.defaults; diff --git a/src/screens/settings/Categories.tsx b/src/screens/settings/Categories.tsx index 535a3b24..ae38d4f8 100644 --- a/src/screens/settings/Categories.tsx +++ b/src/screens/settings/Categories.tsx @@ -56,7 +56,7 @@ export default function Categories() { useEffect(() => { setTitle(t('category.title.categories')); setAction(null); - }, []); + }, [t]); const { data, mutate } = useQuery('/api/v1/category/'); const categories = useMemo(() => { diff --git a/src/screens/settings/DefaultReaderSettings.tsx b/src/screens/settings/DefaultReaderSettings.tsx index d1320e70..edd9a98e 100644 --- a/src/screens/settings/DefaultReaderSettings.tsx +++ b/src/screens/settings/DefaultReaderSettings.tsx @@ -29,7 +29,7 @@ export default function DefaultReaderSettings() { useEffect(() => { setTitle(t('reader.settings.title.default_reader_settings')); setAction(null); - }, []); + }, [t]); const { metadata, settings, loading } = useDefaultReaderSettings();