From b1aaeb4d5d5ce3f54eb64616563b6a81fcbe84a1 Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Sun, 22 Oct 2023 14:47:11 +0200 Subject: [PATCH] Show loading text for include/exclude categories setting Due to setting categories to be an empty array by default, the loading text was never shown --- src/screens/settings/LibrarySettings.tsx | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/screens/settings/LibrarySettings.tsx b/src/screens/settings/LibrarySettings.tsx index 99d0ebcb..cc753005 100644 --- a/src/screens/settings/LibrarySettings.tsx +++ b/src/screens/settings/LibrarySettings.tsx @@ -101,11 +101,15 @@ export default function LibrarySettings() { useSetDefaultBackTo('settings'); const { data, error: requestError } = requestManager.useGetCategories(); - const categories = data?.categories.nodes ?? []; - const [dialogCategories, setDialogCategories] = useState(categories); + const categories = data?.categories.nodes; + const [dialogCategories, setDialogCategories] = useState(categories ?? []); const [isDialogOpen, setIsDialogOpen] = useState(false); useEffect(() => { + if (!categories) { + return; + } + setDialogCategories(categories); }, [categories]); @@ -135,7 +139,7 @@ export default function LibrarySettings() { const updateCategories = async () => { const categoriesToUpdate = dialogCategories.filter((category) => { - const currentCategory = categories.find((currCategory) => currCategory.id === category.id); + const currentCategory = categories?.find((currCategory) => currCategory.id === category.id); if (!currentCategory) { return false;