From 9a738775f1a54f57b9e0ceabf7451ed0d88549f7 Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Wed, 10 Apr 2024 23:46:08 +0200 Subject: [PATCH] Fix/search bar search disappearing after submit (#728) * Correctly update search string on location change Regression introduced with aab3e25031babe13c5df4e64aa57e61a8d8db80c * Remove unnecessary usage of "useSessionStorage" This did not add anything and made no sense --- src/components/util/AppbarSearch.tsx | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/components/util/AppbarSearch.tsx b/src/components/util/AppbarSearch.tsx index dca875d6..8f1b5cdc 100644 --- a/src/components/util/AppbarSearch.tsx +++ b/src/components/util/AppbarSearch.tsx @@ -13,7 +13,6 @@ import { useQueryParam, StringParam } from 'use-query-params'; import { useTranslation } from 'react-i18next'; import { useLocation } from 'react-router-dom'; import { SearchTextField } from '@/components/atoms/SearchTextField.tsx'; -import { useSessionStorage } from '@/util/useStorage.tsx'; interface IProps { isClosable?: boolean; @@ -33,15 +32,13 @@ export const AppbarSearch: React.FunctionComponent = (props) => { const [searchString, setSearchString] = useState(query ?? ''); - const [locationQuery, setLocationQuery] = useSessionStorage(`appbarsearch-location-${location.key}`); if (prevLocationKey !== location.key) { setPrevLocationKey(location.key); - setLocationQuery(query); - setSearchString(locationQuery ?? ''); - setIsSearchOpen(!isClosable || !!locationQuery); + setSearchString(query ?? ''); + setIsSearchOpen(!isClosable || !!query); } - const isOpen = isSearchOpen || !!locationQuery; + const isOpen = isSearchOpen || !!query; const updateSearchOpenState = (open: boolean) => { if (!isClosable) {