ChoChoX/suwayomi-material-you-webui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve "page spread page state" updates

Browse Source 
Since "pagesToSpreadState" isn't part of the dependency array and also would decrease the render performance if it was (see reasoning of c79f7cc874), the array reference might be out of date and thus, the guard might not work correctly
This commit is contained in:
schroda
2024-12-29 17:23:29 +01:00
parent c79f7cc874
commit 94ee7d4958
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/modules/reader/components/viewer/ReaderViewer.tsx
View File

@@ -179,11 +179,17 @@ const BaseReaderViewer = forwardRef(
const img = new Image();
img.onload = () => {
const isSpreadPageFlag = isSpreadPage(img);
if (pagesToSpreadState[index] === isSpreadPageFlag) {
if (!isSpreadPageFlag || pagesToSpreadState[index] === isSpreadPageFlag) {
return;
}
setPagesToSpreadState((prevState) => prevState.toSpliced(index, 1, isSpreadPageFlag));
setPagesToSpreadState((prevState) => {
if (pagesToSpreadState[index] === isSpreadPageFlag) {
return prevState;
}
return prevState.toSpliced(index, 1, isSpreadPageFlag);
});
};
img.src = url;
}
@@ -200,6 +206,8 @@ const BaseReaderViewer = forwardRef(
return statePageLoadStates.toSpliced(index, 1, { loaded: true });
});
},
// do not add "pagesToSpreadState" and "pageLoadStates" as a dependency, otherwise, every page gets re-rendered
// when they change which impacts the performance massively (depending on the total page count)
[actualPages, readingMode],
);