ChoChoX/suwayomi-material-you-webui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove redundant extract helper functions for server settings

Browse Source 
Simplifies settings usage by directly accessing the `settings` object instead of relying on intermediary extraction functions. Improves code readability and reduces unnecessary abstraction.

Ensures consistency across all settings components for a cleaner and more efficient implementation.
This commit is contained in:
schroda
2025-09-08 00:46:57 +02:00
parent 47e93c774f
commit 94299433c8
7 changed files with 8 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/features/downloads/screens/DownloadSettings.tsx
View File

@@ -45,16 +45,6 @@ type DownloadSettingsType = Pick<
| 'downloadConversions'
>;
const extractDownloadSettings = (settings: ServerSettings): DownloadSettingsType => ({
downloadAsCbz: settings.downloadAsCbz,
downloadsPath: settings.downloadsPath,
autoDownloadNewChapters: settings.autoDownloadNewChapters,
autoDownloadNewChaptersLimit: settings.autoDownloadNewChaptersLimit,
excludeEntryWithUnreadChapters: settings.excludeEntryWithUnreadChapters,
autoDownloadIgnoreReUploads: settings.autoDownloadIgnoreReUploads,
downloadConversions: settings.downloadConversions,
});
export const DownloadSettings = () => {
const { t } = useTranslation();
@@ -103,7 +93,7 @@ export const DownloadSettings = () => {
);
}
const downloadSettings = extractDownloadSettings(serverSettings.data!.settings);
const downloadSettings = serverSettings.data!.settings;
const updateSetting = <Setting extends keyof DownloadSettingsType>(
setting: Setting,