From 89e8472ebc6edc50ea9af74429f378394687abda Mon Sep 17 00:00:00 2001
From: schroda <50052685+schroda@users.noreply.github.com>
Date: Tue, 9 Jan 2024 22:09:43 +0100
Subject: [PATCH] Add disclaimer to custom repositories setting (#544)

---
 .../settings/MutableListSetting.tsx           | 35 +++++++++++++++++--
 src/i18n/locale/en.json                       |  1 +
 src/screens/settings/ServerSettings.tsx       | 13 ++++++-
 3 files changed, 45 insertions(+), 4 deletions(-)

diff --git a/src/components/settings/MutableListSetting.tsx b/src/components/settings/MutableListSetting.tsx
index b87b0374..8359b7c2 100644
--- a/src/components/settings/MutableListSetting.tsx
+++ b/src/components/settings/MutableListSetting.tsx
@@ -6,7 +6,7 @@
  * file, You can obtain one at https://mozilla.org/MPL/2.0/.
  */
 
-import { Button, Dialog, DialogTitle, ListItemButton, ListItemText, Stack, Tooltip } from '@mui/material';
+import { Button, Dialog, DialogTitle, ListItemButton, ListItemText, Stack, Tooltip, Typography } from '@mui/material';
 import { useEffect, useState } from 'react';
 import DialogContent from '@mui/material/DialogContent';
 import DialogActions from '@mui/material/DialogActions';
@@ -15,6 +15,7 @@ import List from '@mui/material/List';
 import DeleteIcon from '@mui/icons-material/Delete';
 import IconButton from '@mui/material/IconButton';
 import DialogContentText from '@mui/material/DialogContentText';
+import InfoIcon from '@mui/icons-material/Info';
 import { TextSetting, TextSettingProps } from '@/components/settings/text/TextSetting.tsx';
 import { TextSettingDialog } from '@/components/settings/text/TextSettingDialog.tsx';
 import { makeToast } from '@/components/util/Toast.tsx';
@@ -40,6 +41,7 @@ const MutableListItem = ({
 type MutableListSettingProps = Pick<TextSettingProps, 'settingName' | 'placeholder'> & {
     values?: string[];
     description?: string;
+    dialogDisclaimer?: JSX.Element | string;
     addItemButtonTitle?: string;
     handleChange: (values: string[]) => void;
     allowDuplicates?: boolean;
@@ -50,6 +52,7 @@ type MutableListSettingProps = Pick<TextSettingProps, 'settingName' | 'placehold
 export const MutableListSetting = ({
     settingName,
     description,
+    dialogDisclaimer,
     values,
     handleChange,
     addItemButtonTitle,
@@ -122,9 +125,35 @@ export const MutableListSetting = ({
 
             <Dialog open={isDialogOpen} onClose={() => closeDialog()} fullWidth>
                 <DialogTitle>{settingName}</DialogTitle>
-                {!!description && (
+                {(!!description || !!dialogDisclaimer) && (
                     <DialogContent>
-                        <DialogContentText sx={{ paddingBottom: '10px' }}>{description}</DialogContentText>
+                        <DialogContentText sx={{ paddingBottom: '10px' }} component="div">
+                            {description && (
+                                <Typography
+                                    variant="body1"
+                                    sx={{
+                                        whiteSpace: 'pre-line',
+                                    }}
+                                >
+                                    {description}
+                                </Typography>
+                            )}
+                            {dialogDisclaimer && (
+                                <Stack direction="row" alignItems="center">
+                                    <InfoIcon color="warning" />
+                                    <Typography
+                                        variant="body1"
+                                        sx={{
+                                            marginLeft: '10px',
+                                            marginTop: '5px',
+                                            whiteSpace: 'pre-line',
+                                        }}
+                                    >
+                                        {dialogDisclaimer}
+                                    </Typography>
+                                </Stack>
+                            )}
+                        </DialogContentText>
                     </DialogContent>
                 )}
                 <DialogContent dividers sx={{ maxHeight: '300px' }}>
diff --git a/src/i18n/locale/en.json b/src/i18n/locale/en.json
index b20e61f8..09153795 100644
--- a/src/i18n/locale/en.json
+++ b/src/i18n/locale/en.json
@@ -250,6 +250,7 @@
           },
           "label": {
             "description": "Add custom repositories from which extensions can be installed",
+            "disclaimer": "<strong>Suwayomi does not provide any support for 3rd party repositories or extensions!</strong><br/>Use with caution as there could be malicious actors making those repositories.<br/>You as the user need to verify the security and that you trust any repository or extension.",
             "title": "Custom repositories"
           }
         }
diff --git a/src/screens/settings/ServerSettings.tsx b/src/screens/settings/ServerSettings.tsx
index 0fed83a9..e68a855f 100644
--- a/src/screens/settings/ServerSettings.tsx
+++ b/src/screens/settings/ServerSettings.tsx
@@ -6,7 +6,7 @@
  * file, You can obtain one at https://mozilla.org/MPL/2.0/.
  */
 
-import { useTranslation } from 'react-i18next';
+import { useTranslation, Trans } from 'react-i18next';
 import { useContext, useEffect } from 'react';
 import { List, ListItem, ListItemText, Switch } from '@mui/material';
 import ListSubheader from '@mui/material/ListSubheader';
@@ -133,6 +133,17 @@ export const ServerSettings = () => {
                 <MutableListSetting
                     settingName={t('extension.settings.repositories.custom.label.title')}
                     description={t('extension.settings.repositories.custom.label.description')}
+                    dialogDisclaimer={
+                        <Trans i18nKey="extension.settings.repositories.custom.label.disclaimer">
+                            <strong>
+                                Suwayomi does not provide any support for 3rd party repositories or extensions!
+                            </strong>
+                            <br />
+                            Use with caution as there could be malicious actors making those repositories.
+                            <br />
+                            You as the user need to verify the security and that you trust any repository or extension.
+                        </Trans>
+                    }
                     handleChange={(repos) => updateSetting('extensionRepos', repos)}
                     values={serverSettings?.extensionRepos}
                     addItemButtonTitle={t('extension.settings.repositories.custom.dialog.action.button.add')}