Fix missing pinned sources in source language filter

This commit is contained in:
schroda
2026-01-14 23:37:46 +01:00
parent cfc0e672ef
commit 7ef353aa2e
4 changed files with 10 additions and 9 deletions

View File

@@ -29,10 +29,9 @@ interface IProps {
languages: string[];
}
export function LanguageSelect(props: IProps) {
export function LanguageSelect({ selectedLanguages, setSelectedLanguages, languages }: IProps) {
const { t } = useLingui();
const { selectedLanguages, setSelectedLanguages, languages } = props;
const [tmpSelectedLanguages, setTmpSelectedLanguages] = useState(toUniqueLanguageCodes(selectedLanguages));
const [open, setOpen] = useState<boolean>(false);

View File

@@ -58,7 +58,9 @@ export function Sources({ tabsMenuHeight }: { tabsMenuHeight: number }) {
);
const sourcesByLanguage = useMemo(() => {
const lastUsedSource = SourceService.getLastUsedSource(lastUsedSourceId, filteredSources);
const groupedByLanguageTuple = Object.entries(SourceService.groupByLanguage(filteredSources));
const groupedByLanguageTuple = Object.entries(
SourceService.groupByLanguage(filteredSources, { withPinnedGroup: true }),
);
if (lastUsedSource) {
return [

View File

@@ -52,9 +52,10 @@ export class Sources {
static groupByLanguage<Source extends SourceIdInfo & SourceLanguageInfo & SourceDisplayNameInfo & SourceMetaInfo>(
sources: Source[],
{ withPinnedGroup = false }: { withPinnedGroup?: boolean } = {},
): Record<string, Source[]> {
const sourcesByLanguage = Object.groupBy(sources, (source) => {
if (getSourceMetadata(source).isPinned) {
if (withPinnedGroup && getSourceMetadata(source).isPinned) {
return DefaultLanguage.PINNED;
}
@@ -64,11 +65,11 @@ export class Sources {
const isAPinned = a === DefaultLanguage.PINNED;
const isBPinned = b === DefaultLanguage.PINNED;
if (isAPinned) {
if (withPinnedGroup && isAPinned) {
return -1;
}
if (isBPinned) {
if (withPinnedGroup && isBPinned) {
return 1;
}