From 6e1a204c29b3dad7674396ba56e08cfe8e71da9f Mon Sep 17 00:00:00 2001
From: schroda <50052685+schroda@users.noreply.github.com>
Date: Sat, 13 Jul 2024 17:05:46 +0200
Subject: [PATCH] Include already detected duplicates for different title

Duplicates were ignored in case they were already detected before.
However, this did not work as intended and ignored valid duplicates in case they were already detected for a different title
---
 src/screens/settings/LibraryDuplicates.tsx | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/screens/settings/LibraryDuplicates.tsx b/src/screens/settings/LibraryDuplicates.tsx
index a626b643..e4ffc67a 100644
--- a/src/screens/settings/LibraryDuplicates.tsx
+++ b/src/screens/settings/LibraryDuplicates.tsx
@@ -32,7 +32,6 @@ import {
     MangaType,
 } from '@/lib/graphql/generated/graphql.ts';
 import { GET_MANGAS_DUPLICATES } from '@/lib/graphql/queries/MangaQuery.ts';
-import { MangaIdInfo } from '@/lib/data/Mangas.ts';
 import { BaseMangaGrid } from '@/components/source/BaseMangaGrid.tsx';
 import { IMangaGridProps } from '@/components/MangaGrid.tsx';
 import { StyledGroupItemWrapper } from '@/components/virtuoso/StyledGroupItemWrapper.tsx';
@@ -59,7 +58,6 @@ type TMangaDuplicate = Pick<MangaType, 'id' | 'title' | 'description'>;
 const findDuplicatesByTitleAndAlternativeTitles = <Manga extends TMangaDuplicate>(
     libraryMangas: Manga[],
 ): Record<string, Manga[]> => {
-    const idToDuplicateStatus: Record<MangaIdInfo['id'], boolean> = {};
     const titleToMangas: Record<string, Set<Manga>> = {};
     const titleToAlternativeTitleMatches: Record<string, Set<Manga>> = {};
 
@@ -86,14 +84,6 @@ const findDuplicatesByTitleAndAlternativeTitles = <Manga extends TMangaDuplicate
                 return;
             }
 
-            const wasAlreadyDetected = idToDuplicateStatus[libraryManga.id];
-            if (wasAlreadyDetected) {
-                return;
-            }
-
-            idToDuplicateStatus[mangaToCheck.id] = true;
-            idToDuplicateStatus[libraryManga.id] = true;
-
             if (doesTitleMatch) {
                 titleToMangas[titleToCheck].add(libraryManga);
             }