From 6c8df33a13fa053688375dd9f1ad36c33a75256f Mon Sep 17 00:00:00 2001
From: schroda <50052685+schroda@users.noreply.github.com>
Date: Sat, 11 Jan 2025 03:17:49 +0100
Subject: [PATCH] Delete outdated metadata after committing updated ones

In case the outdated metadata get successfully deleted and the updated metadata fail to commit, metadata gets lost, due to not being able to apply the migrations again since the outdated metadata have already been deleted
---
 src/modules/metadata/services/MetadataMigrations.ts | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/modules/metadata/services/MetadataMigrations.ts b/src/modules/metadata/services/MetadataMigrations.ts
index 13064112..8b10b93b 100644
--- a/src/modules/metadata/services/MetadataMigrations.ts
+++ b/src/modules/metadata/services/MetadataMigrations.ts
@@ -309,12 +309,9 @@ const commitMigratedMetadata = (
             commitedMigrations.add(itemMigrationKey);
 
             try {
+                await updateMetadata([...metadataToUpdate], undefined, true);
                 await deleteMetadata(metadataKeysToDelete, undefined, true);
-                await updateMetadata(
-                    [...metadataToUpdate, [getMetadataKey('migration') as AppMetadataKeys, METADATA_MIGRATIONS.length]],
-                    undefined,
-                    true,
-                );
+                await updateMetadata([['migration', METADATA_MIGRATIONS.length]]);
             } catch (e) {
                 commitedMigrations.delete(itemMigrationKey);