From 670508e08586ee1890dc17e3bc57517b23a3ee63 Mon Sep 17 00:00:00 2001
From: abhijeetChawla <abhijeetchawla22@gmail.com>
Date: Mon, 20 Dec 2021 14:13:49 +0530
Subject: [PATCH] Refactor for Removing unnecesary UseEffect (#118)

---
 src/screens/Extensions.tsx | 44 +++++++++++++-------------------------
 1 file changed, 15 insertions(+), 29 deletions(-)

diff --git a/src/screens/Extensions.tsx b/src/screens/Extensions.tsx
index 2d1bdee5..887e95b8 100644
--- a/src/screens/Extensions.tsx
+++ b/src/screens/Extensions.tsx
@@ -68,8 +68,6 @@ export default function MangaExtensions() {
     const [showNsfw] = useLocalStorage<boolean>('showNsfw', true);
     const theme = useTheme();
     const isMobile = useMediaQuery(theme.breakpoints.down('sm'));
-
-    const [flatRenderItems, setFlatRenderItems] = useState<(IExtension | string)[]>([]);
     const [query] = useQueryParam('query', StringParam);
 
     useEffect(() => {
@@ -105,32 +103,6 @@ export default function MangaExtensions() {
             .then((data) => setExtensionsRaw(data));
     }, [updateTriggerHolder]);
 
-    useEffect(() => {
-        if (extensionsRaw.length > 0) {
-            const filtered = extensionsRaw.filter((ext) => {
-                const nsfwFilter = showNsfw || !ext.isNsfw;
-                if (!query) return nsfwFilter;
-                return nsfwFilter && ext.name.toLowerCase().includes(query.toLowerCase());
-            });
-
-            const combinedShownLangs = ['installed', 'updates pending', 'all', ...shownLangs];
-
-            const groupedExtensions: [string, IExtension[]][] = groupExtensions(filtered)
-                .filter((group) => group[EXTENSIONS].length > 0)
-                .filter((group) => combinedShownLangs.includes(group[LANGUAGE]));
-
-            // Virtual List set up
-            const flatExtensions = [] as (IExtension | string)[];
-
-            groupedExtensions.forEach((group) => {
-                flatExtensions.push(group[LANGUAGE]);
-                group[1].forEach((it) => flatExtensions.push(it));
-            });
-
-            setFlatRenderItems(flatExtensions);
-        }
-    }, [extensionsRaw, query, shownLangs]);
-
     const [toasts, makeToast] = makeToaster(useState<React.ReactElement[]>([]));
 
     const submitExternalExtension = (file: File) => {
@@ -182,12 +154,26 @@ export default function MangaExtensions() {
             document.removeEventListener('dragover', dragOverHandler);
             input?.removeEventListener('change', changeHandler);
         };
-    }, [flatRenderItems]); // useEffect only after <input> renders
+    }, [extensionsRaw]); // useEffect only after <input> renders
 
     if (extensionsRaw.length === 0) {
         return <LoadingPlaceholder />;
     }
 
+    const filtered = extensionsRaw.filter((ext) => {
+        const nsfwFilter = showNsfw || !ext.isNsfw;
+        if (!query) return nsfwFilter;
+        return nsfwFilter && ext.name.toLowerCase().includes(query.toLowerCase());
+    });
+
+    const combinedShownLangs = ['installed', 'updates pending', 'all', ...shownLangs];
+
+    const groupedExtensions: [string, IExtension[]][] = groupExtensions(filtered)
+        .filter((group) => group[EXTENSIONS].length > 0)
+        .filter((group) => combinedShownLangs.includes(group[LANGUAGE]));
+
+    const flatRenderItems: (IExtension | string)[] = groupedExtensions.flat(2);
+
     return (
         <>
             {toasts}