Prevent sending requests that are known to fail

In case it's still unknown if auth is set up on the server, only the initial request to detect this should be sent. Since all other requests will also just fail, they should be blocked until the auth initialization is completed.

While the access token is getting refreshed, no request will succeed since the access token is expired; thus, they should not be sent.
This commit is contained in:
schroda
2025-10-15 02:50:43 +02:00
parent 17a811cd39
commit 6636cc66b1
7 changed files with 186 additions and 64 deletions

View File

@@ -11,6 +11,13 @@ import { UserRefreshMutation } from '@/lib/graphql/generated/graphql.ts';
import { AuthManager } from '@/features/authentication/AuthManager.ts';
import { AbortableApolloMutationResponse } from '@/lib/requests/RequestManager.ts';
import { SubpathUtil } from '@/lib/utils/SubpathUtil.ts';
import { ControlledPromise } from '@/lib/ControlledPromise.ts';
interface QueuedRequest {
execute: () => void;
resolve: (value: any) => void;
reject: (error: any) => void;
}
export abstract class BaseClient<Client, ClientConfig, Fetcher> {
protected abstract client: Client;
@@ -19,6 +26,14 @@ export abstract class BaseClient<Client, ClientConfig, Fetcher> {
private static activeTokenRefreshPromise: Promise<UserRefreshMutation | null | undefined> | null = null;
private static onTokenRefreshComplete: (() => void) | null = null;
protected requestQueue: QueuedRequest[] = [];
public static setTokenRefreshCompleteCallback(callback: (() => void) | null): void {
BaseClient.onTokenRefreshComplete = callback;
}
protected static async refreshAccessToken(
refreshFn: (refreshToken: string) => AbortableApolloMutationResponse<UserRefreshMutation>,
): Promise<UserRefreshMutation | null | undefined> {
@@ -36,6 +51,8 @@ export abstract class BaseClient<Client, ClientConfig, Fetcher> {
return this.activeTokenRefreshPromise;
}
AuthManager.setIsRefreshingToken(true);
const refreshRequest = refreshFn(refreshToken).response;
this.activeTokenRefreshPromise = refreshRequest.then((result) => result.data);
@@ -48,6 +65,9 @@ export abstract class BaseClient<Client, ClientConfig, Fetcher> {
}
AuthManager.setAccessToken(data.refreshToken.accessToken);
AuthManager.setAuthInitialized(true);
BaseClient.onTokenRefreshComplete?.();
return data;
} catch (e) {
@@ -55,6 +75,7 @@ export abstract class BaseClient<Client, ClientConfig, Fetcher> {
throw e;
} finally {
this.activeTokenRefreshPromise = null;
AuthManager.setIsRefreshingToken(false);
}
}
@@ -75,5 +96,45 @@ export abstract class BaseClient<Client, ClientConfig, Fetcher> {
return SubpathUtil.getApiBaseUrl(serverBaseURL);
}
// eslint-disable-next-line @typescript-eslint/no-unused-vars
protected shouldQueueRequest(operationName?: string): boolean {
return AuthManager.shouldQueueRequests();
}
protected enqueueRequest<T>(executor: () => Promise<T>, operationName?: string): Promise<T> {
if (!this.shouldQueueRequest(operationName)) {
return executor();
}
const { promise: requestPromise, reject, resolve } = new ControlledPromise<T>();
this.requestQueue.push({
execute: () => {
executor().then(resolve).catch(reject);
},
resolve,
reject,
});
return requestPromise;
}
public processQueue(): void {
const queue = [...this.requestQueue];
this.requestQueue = [];
queue.forEach((request) => {
request.execute();
});
}
protected clearQueue(error?: Error): void {
const queue = [...this.requestQueue];
this.requestQueue = [];
queue.forEach((request) => {
request.reject(error ?? new Error('Request queue cleared'));
});
}
public abstract updateConfig(config: Partial<ClientConfig>): void;
}