From 5aec8282cb1c13f40562a3ba83aeae16eb151615 Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Sun, 6 Oct 2024 16:39:13 +0200 Subject: [PATCH] Properly abort source searches on query change --- src/modules/global-search/screens/SearchAll.tsx | 2 +- src/modules/source/screens/SourceMangas.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/global-search/screens/SearchAll.tsx b/src/modules/global-search/screens/SearchAll.tsx index 1239e3c5..647a1f8b 100644 --- a/src/modules/global-search/screens/SearchAll.tsx +++ b/src/modules/global-search/screens/SearchAll.tsx @@ -137,7 +137,7 @@ const SourceSearchPreview = React.memo( // immediate second request since it's the same key. instead the "second" request will be the error handling of SWR abortRequest(new Error(`SourceSearchPreview(${id}, ${displayName}): search string changed`)); }, - [searchString], + [searchString, abortRequest], ); if ((!isLoading && !searchString) || emptyQuery) { diff --git a/src/modules/source/screens/SourceMangas.tsx b/src/modules/source/screens/SourceMangas.tsx index b5a9e758..842e34f8 100644 --- a/src/modules/source/screens/SourceMangas.tsx +++ b/src/modules/source/screens/SourceMangas.tsx @@ -400,7 +400,7 @@ export function SourceMangas() { abortRequest(new Error(`SourceMangas(${sourceId}): search string changed`)); scrollToTop(); }, - [query], + [query, abortRequest], ); useLayoutEffect(() => {