Hide chapter transition page in single/double pagers
Transition page got opened and never closed again due to not correctly detecting that a transition page is currently visible
This commit is contained in:
@@ -281,7 +281,6 @@ export class ReaderControls {
|
||||
const isFirstPage = currentPage.primary.index === 0;
|
||||
const isLastPage = currentPageIndex === indexOfLastPage;
|
||||
const isATransitionPageVisible = isTransitionPageVisible(transitionPageMode, readingMode.value);
|
||||
const isContinuousReadingModeActive = isContinuousReadingMode(readingMode.value);
|
||||
|
||||
return useCallback(
|
||||
(page, forceDirection = direction, hideOverlay: boolean = true) => {
|
||||
@@ -318,7 +317,7 @@ export class ReaderControls {
|
||||
return;
|
||||
}
|
||||
|
||||
const needToHideTransitionPage = isATransitionPageVisible && !isContinuousReadingModeActive;
|
||||
const needToHideTransitionPage = isATransitionPageVisible;
|
||||
switch (convertedPage) {
|
||||
case 'previous':
|
||||
if (isFirstPage) {
|
||||
@@ -360,7 +359,6 @@ export class ReaderControls {
|
||||
nextPageIndex,
|
||||
indexOfLastPage,
|
||||
isATransitionPageVisible,
|
||||
isContinuousReadingModeActive,
|
||||
isFirstPage,
|
||||
isLastPage,
|
||||
openChapter,
|
||||
|
||||
@@ -484,9 +484,10 @@ export const getPageIndexesToLoad = (
|
||||
export const isTransitionPageVisible = (
|
||||
activeMode: ReaderTransitionPageMode,
|
||||
readingMode: IReaderSettings['readingMode'],
|
||||
transitionPageType?: ReaderTransitionPageMode,
|
||||
transitionPageType: ReaderTransitionPageMode = activeMode,
|
||||
): boolean =>
|
||||
[ReaderTransitionPageMode.BOTH, transitionPageType].includes(activeMode) || isContinuousReadingMode(readingMode);
|
||||
(activeMode !== ReaderTransitionPageMode.NONE && activeMode === transitionPageType) ||
|
||||
isContinuousReadingMode(readingMode);
|
||||
|
||||
export const getScrollIntoViewInlineOption = (
|
||||
offset: DirectionOffset,
|
||||
|
||||
Reference in New Issue
Block a user