Introduce "sources" util class

src/modules/source/Source.types.ts

@@ -10,6 +10,7 @@ import {
     GetSourceBrowseQuery,
     GetSourceSettingsQuery,
     SourcePreferenceChangeInput,
+    SourceType,
 } from '@/lib/graphql/generated/graphql.ts';
 
 export interface IPos {
@@ -57,3 +58,5 @@ export type MultiSelectListPreferenceProps = PreferenceProps &
 
 export type EditTextPreferenceProps = PreferenceProps &
     ExtractByKeyValue<SourcePreferences, '__typename', 'EditTextPreference'>;
+
+export type SourceIdInfo = Pick<SourceType, 'id'>;

src/modules/source/components/SourceCard.tsx

@@ -36,21 +36,18 @@ export const SourceCard: React.FC<IProps> = (props: IProps) => {
 
     const isMobileWidth = MediaQuery.useIsMobileWidth();
 
+    const { source, showSourceRepo } = props;
     const {
-        source: {
-            id,
-            name,
-            lang,
-            iconUrl,
-            supportsLatest,
-            isNsfw,
-            extension: { repo },
-        },
-        showSourceRepo,
-    } = props;
+        id,
+        name,
+        lang,
+        iconUrl,
+        supportsLatest,
+        isNsfw,
+        extension: { repo },
+    } = source;
 
-    const isLocalSource = Number(id) === 0;
-    const sourceName = isLocalSource ? t('source.local_source.title') : name;
+    const sourceName = Sources.isLocalSource(source) ? t('source.local_source.title') : name;
 
     return (
         <Card

src/modules/source/screens/SourceMangas.tsx

@@ -34,7 +34,6 @@ import {
     GetSourceBrowseQueryVariables,
     GetSourceMangasFetchMutation,
     GetSourceMangasFetchMutationVariables,
-    SourceType,
 } from '@/lib/graphql/generated/graphql.ts';
 import { useMetadataServerSettings } from '@/modules/settings/services/ServerSettingsMetadata.ts';
 import { useLocalStorage, useSessionStorage } from '@/modules/core/hooks/useStorage.tsx';
@@ -44,7 +43,7 @@ import { createUpdateSourceMetadata, useGetSourceMetadata } from '@/modules/sour
 import { makeToast } from '@/modules/core/utils/Toast.ts';
 import { GET_SOURCE_BROWSE } from '@/lib/graphql/queries/SourceQuery.ts';
 import { TranslationKey } from '@/Base.types.ts';
-import { IPos } from '@/modules/source/Source.types.ts';
+import { IPos, SourceIdInfo } from '@/modules/source/Source.types.ts';
 import { defaultPromiseErrorHandler } from '@/lib/DefaultPromiseErrorHandler.ts';
 import { EmptyView } from '@/modules/core/components/placeholder/EmptyView.tsx';
 import { EmptyViewAbsoluteCentered } from '@/modules/core/components/placeholder/EmptyViewAbsoluteCentered.tsx';
@@ -53,8 +52,9 @@ import { GridLayout } from '@/modules/core/Core.types.ts';
 import { AppRoutes } from '@/modules/core/AppRoute.constants.ts';
 import { getErrorMessage } from '@/lib/HelperFunctions.ts';
 import { useNavBarContext } from '@/modules/navigation-bar/contexts/NavbarContext.tsx';
+import { Sources } from '@/modules/source/services/Sources.ts';
 
-const DEFAULT_SOURCE: Pick<SourceType, 'id'> = { id: '-1' };
+const DEFAULT_SOURCE: SourceIdInfo = { id: '-1' };
 
 const ContentTypeMenu = styled('div')(({ theme }) => ({
     display: 'flex',
@@ -332,7 +332,7 @@ export function SourceMangas() {
     );
 
     const message = !isLoading ? t(SOURCE_CONTENT_TYPE_TO_ERROR_MSG_KEY[contentType]) : undefined;
-    const isLocalSource = sourceId === '0';
+    const isLocalSource = sourceId === Sources.LOCAL_SOURCE_ID;
     const messageExtra = isLocalSource ? (
         <>
             <span>{t('source.local_source.label.checkout')} </span>

src/modules/source/screens/Sources.tsx

@@ -26,13 +26,13 @@ import { translateExtensionLanguage } from '@/modules/extension/Extensions.utils
 import { AppRoutes } from '@/modules/core/AppRoute.constants.ts';
 import { getErrorMessage } from '@/lib/HelperFunctions.ts';
 import { useNavBarContext } from '@/modules/navigation-bar/contexts/NavbarContext.tsx';
+import { Sources as SourceService } from '@/modules/source/services/Sources.ts';
 
 function sourceToLangList(sources: Pick<SourceType, 'id' | 'lang'>[]) {
     const result = new Set<string>();
 
     sources.forEach((source) => {
-        const isLocalSource = Number(source.id) === 0;
-        const lang = isLocalSource ? DefaultLanguage.OTHER : source.lang;
+        const lang = SourceService.isLocalSource(source) ? DefaultLanguage.OTHER : source.lang;
 
         result.add(lang);
     });
@@ -46,8 +46,7 @@ function groupByLang<Source extends Pick<SourceType, 'id' | 'name' | 'lang'>>(
     const result: Record<string, Source[]> = {};
 
     sources.forEach((source) => {
-        const isLocalSource = Number(source.id) === 0;
-        const lang = isLocalSource ? DefaultLanguage.OTHER : source.lang;
+        const lang = SourceService.isLocalSource(source) ? DefaultLanguage.OTHER : source.lang;
 
         result[lang] ??= [];
         result[lang].push(source);
@@ -146,7 +145,7 @@ export function Sources() {
                                     .filter((source) => {
                                         const isLangOther = lang === DefaultLanguage.OTHER;
                                         if (isLangOther) {
-                                            const isLocalSource = Number(source.id) === 0;
+                                            const isLocalSource = SourceService.isLocalSource(source);
                                             const isLangShown = shownLangs.includes(lang);
 
                                             const isLangOtherSourceShown = isLangShown || isLocalSource;

src/modules/source/services/SourceMetadata.ts

@@ -10,8 +10,7 @@ import { useEffect, useMemo } from 'react';
 import { jsonSaveParse } from '@/lib/HelperFunctions.ts';
 import { requestUpdateSourceMetadata } from '@/modules/metadata/services/MetadataUpdater.ts';
 import { defaultPromiseErrorHandler } from '@/lib/DefaultPromiseErrorHandler.ts';
-import { SourceType } from '@/lib/graphql/generated/graphql.ts';
-import { ISourceMetadata, SourceMetadataKeys } from '@/modules/source/Source.types.ts';
+import { ISourceMetadata, SourceIdInfo, SourceMetadataKeys } from '@/modules/source/Source.types.ts';
 import { convertFromGqlMeta } from '@/modules/metadata/services/MetadataConverter.ts';
 import { getMetadataFrom } from '@/modules/metadata/services/MetadataReader.ts';
 import {
@@ -39,10 +38,7 @@ const convertGqlMetadataToAppMetadata = (
     savedSearches: jsonSaveParse<ISourceMetadata['savedSearches']>(metadata.savedSearches as string) ?? undefined,
 });
 
-const getMetadata = (
-    metaHolder: Pick<SourceType, 'id'> & GqlMetaHolder,
-    useEffectFn?: typeof useEffect,
-): ISourceMetadata =>
+const getMetadata = (metaHolder: SourceIdInfo & GqlMetaHolder, useEffectFn?: typeof useEffect): ISourceMetadata =>
     convertGqlMetadataToAppMetadata(
         getMetadataFrom(
             'source',
@@ -53,10 +49,9 @@ const getMetadata = (
         ),
     );
 
-export const getSourceMetadata = (metaHolder: Pick<SourceType, 'id'> & GqlMetaHolder): ISourceMetadata =>
-    getMetadata(metaHolder);
+export const getSourceMetadata = (metaHolder: SourceIdInfo & GqlMetaHolder): ISourceMetadata => getMetadata(metaHolder);
 
-export const useGetSourceMetadata = (metaHolder: Pick<SourceType, 'id'> & GqlMetaHolder): ISourceMetadata => {
+export const useGetSourceMetadata = (metaHolder: SourceIdInfo & GqlMetaHolder): ISourceMetadata => {
     const metadata = getMetadata(metaHolder, useEffect);
     return useMemo(() => metadata, [metaHolder]);
 };
@@ -65,7 +60,7 @@ export const updateSourceMetadata = async <
     MetadataKeys extends SourceMetadataKeys = SourceMetadataKeys,
     MetadataKey extends MetadataKeys = MetadataKeys,
 >(
-    source: Pick<SourceType, 'id'> & GqlMetaHolder,
+    source: SourceIdInfo & GqlMetaHolder,
     metadataKey: MetadataKey,
     value: ISourceMetadata[MetadataKey],
 ): Promise<void[]> =>
@@ -75,7 +70,7 @@ export const updateSourceMetadata = async <
 
 export const createUpdateSourceMetadata =
     <Settings extends SourceMetadataKeys>(
-        source: Pick<SourceType, 'id'> & GqlMetaHolder,
+        source: SourceIdInfo & GqlMetaHolder,
         handleError: (error: any) => void = defaultPromiseErrorHandler('createUpdateSourceMetadata'),
     ): ((...args: OmitFirst<Parameters<typeof updateSourceMetadata<Settings>>>) => Promise<void | void[]>) =>
     (metadataKey, value) =>

src/modules/source/services/Sources.ts

@@ -0,0 +1,17 @@
+/*
+ * Copyright (C) Contributors to the Suwayomi project
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ */
+
+import { SourceIdInfo } from '@/modules/source/Source.types.ts';
+
+export class Sources {
+    static readonly LOCAL_SOURCE_ID = '0';
+
+    static isLocalSource(source: SourceIdInfo): boolean {
+        return source.id === Sources.LOCAL_SOURCE_ID;
+    }
+}