From 3ca4aa2effed127ac1a584eb0889f10b6ee4b727 Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Mon, 17 Mar 2025 12:05:22 +0100 Subject: [PATCH] Remove "Settings" from setting page titles --- public/locales/en.json | 19 +++++-------------- src/modules/browse/screens/BrowseSettings.tsx | 2 +- src/modules/device/screens/DeviceSetting.tsx | 2 +- .../downloads/screens/DownloadSettings.tsx | 2 +- .../library/screens/LibrarySettings.tsx | 2 +- .../ReaderNavBarDesktopQuickSettings.tsx | 2 +- .../reader/screens/GlobalReaderSettings.tsx | 2 +- .../settings/screens/ServerSettings.tsx | 2 +- src/modules/settings/screens/Settings.tsx | 2 +- .../settings/screens/WebUISettings.tsx | 2 +- .../tracker/screens/TrackingSettings.tsx | 2 +- 11 files changed, 15 insertions(+), 24 deletions(-) diff --git a/public/locales/en.json b/public/locales/en.json index 7b3f616d..4e4e7e3a 100644 --- a/public/locales/en.json +++ b/public/locales/en.json @@ -230,8 +230,7 @@ "label": { "cbz": "Save as CBZ archive" } - }, - "title": "Download settings" + } }, "state": { "label": { @@ -682,8 +681,7 @@ } }, "title": "Global update" - }, - "title": "Library Settings" + } }, "title": "Library" }, @@ -996,7 +994,7 @@ }, "title": { "quick_settings": "Quick settings", - "reader_settings": "Reader Settings" + "reader": "Reader" } }, "title": "Reader — Manga {{mangaId}} Chapter {{chapterIndex}}", @@ -1169,9 +1167,6 @@ }, "title": "Backup" }, - "browse": { - "title": "Browse settings" - }, "clear_cache": { "label": { "description": "The cache of the client (browser, electron) should get cleared alongside it, otherwise, the client cache will keep getting used", @@ -1198,8 +1193,7 @@ "placeholder": "Smartphone_Name-1 | length: 16, chars: letters, numbers, -, _" }, "title": { - "device": "Device", - "settings": "Device settings" + "device": "Device" } }, "label": { @@ -1347,8 +1341,7 @@ "title": "SOCKS proxy" }, "title": { - "server": "Server", - "settings": "Server Settings" + "server": "Server" } }, "title": "Settings", @@ -1432,7 +1425,6 @@ "initial_open_browser": "Open the $t(settings.webui.title.webui) when starting the server" }, "title": { - "settings": "$t(settings.webui.title.webui) Settings", "webui": "WebUI" } } @@ -1514,7 +1506,6 @@ "update_progress_reading_description": "Does not work when marking multiple manga as read at once" }, "title": { - "settings": "Tracking settings", "trackers": "Trackers" } }, diff --git a/src/modules/browse/screens/BrowseSettings.tsx b/src/modules/browse/screens/BrowseSettings.tsx index 6d20d8ec..657c25f1 100644 --- a/src/modules/browse/screens/BrowseSettings.tsx +++ b/src/modules/browse/screens/BrowseSettings.tsx @@ -43,7 +43,7 @@ export const BrowseSettings = () => { const { setTitle, setAction } = useNavBarContext(); useLayoutEffect(() => { - setTitle(t('settings.browse.title')); + setTitle(t('global.label.browse')); setAction(null); }, [t]); diff --git a/src/modules/device/screens/DeviceSetting.tsx b/src/modules/device/screens/DeviceSetting.tsx index 3159b875..86f4f6b5 100644 --- a/src/modules/device/screens/DeviceSetting.tsx +++ b/src/modules/device/screens/DeviceSetting.tsx @@ -33,7 +33,7 @@ export const DeviceSetting = () => { const { setTitle, setAction } = useNavBarContext(); useLayoutEffect(() => { - setTitle(t('settings.device.title.settings')); + setTitle(t('settings.device.title.device')); setAction(null); return () => { diff --git a/src/modules/downloads/screens/DownloadSettings.tsx b/src/modules/downloads/screens/DownloadSettings.tsx index e7e37728..3fd84629 100644 --- a/src/modules/downloads/screens/DownloadSettings.tsx +++ b/src/modules/downloads/screens/DownloadSettings.tsx @@ -58,7 +58,7 @@ export const DownloadSettings = () => { const { setTitle, setAction } = useNavBarContext(); useLayoutEffect(() => { - setTitle(t('download.settings.title')); + setTitle(t('download.title.download')); setAction(null); return () => { diff --git a/src/modules/library/screens/LibrarySettings.tsx b/src/modules/library/screens/LibrarySettings.tsx index 6fdd9a84..09c03a8b 100644 --- a/src/modules/library/screens/LibrarySettings.tsx +++ b/src/modules/library/screens/LibrarySettings.tsx @@ -67,7 +67,7 @@ export function LibrarySettings() { const { setTitle, setAction } = useNavBarContext(); useLayoutEffect(() => { - setTitle(t('library.settings.title')); + setTitle(t('library.title')); setAction(null); return () => { diff --git a/src/modules/reader/components/overlay/navigation/desktop/quick-settings/ReaderNavBarDesktopQuickSettings.tsx b/src/modules/reader/components/overlay/navigation/desktop/quick-settings/ReaderNavBarDesktopQuickSettings.tsx index d63e1d75..797756f5 100644 --- a/src/modules/reader/components/overlay/navigation/desktop/quick-settings/ReaderNavBarDesktopQuickSettings.tsx +++ b/src/modules/reader/components/overlay/navigation/desktop/quick-settings/ReaderNavBarDesktopQuickSettings.tsx @@ -84,7 +84,7 @@ const BaseReaderNavBarDesktopQuickSettings = ({ variant="contained" startIcon={} > - {t('reader.settings.title.reader_settings')} + {t('reader.settings.title.reader')} ); diff --git a/src/modules/reader/screens/GlobalReaderSettings.tsx b/src/modules/reader/screens/GlobalReaderSettings.tsx index ec23d5a8..16286915 100644 --- a/src/modules/reader/screens/GlobalReaderSettings.tsx +++ b/src/modules/reader/screens/GlobalReaderSettings.tsx @@ -24,7 +24,7 @@ export const GlobalReaderSettings = () => { const { setTitle, setAction } = useNavBarContext(); useLayoutEffect(() => { - setTitle(t('reader.settings.title.reader_settings')); + setTitle(t('reader.settings.title.reader')); setAction(null); return () => { diff --git a/src/modules/settings/screens/ServerSettings.tsx b/src/modules/settings/screens/ServerSettings.tsx index 99381af2..2d56fbac 100644 --- a/src/modules/settings/screens/ServerSettings.tsx +++ b/src/modules/settings/screens/ServerSettings.tsx @@ -97,7 +97,7 @@ export const ServerSettings = () => { const { setTitle, setAction } = useNavBarContext(); useLayoutEffect(() => { - setTitle(t('settings.server.title.settings')); + setTitle(t('settings.server.title.server')); setAction(null); return () => { diff --git a/src/modules/settings/screens/Settings.tsx b/src/modules/settings/screens/Settings.tsx index 6d1ac4ae..fe7d6b4a 100644 --- a/src/modules/settings/screens/Settings.tsx +++ b/src/modules/settings/screens/Settings.tsx @@ -67,7 +67,7 @@ export function Settings() { - + diff --git a/src/modules/settings/screens/WebUISettings.tsx b/src/modules/settings/screens/WebUISettings.tsx index 8df6946d..e2911316 100644 --- a/src/modules/settings/screens/WebUISettings.tsx +++ b/src/modules/settings/screens/WebUISettings.tsx @@ -123,7 +123,7 @@ export const WebUISettings = () => { const { setTitle, setAction } = useNavBarContext(); useLayoutEffect(() => { - setTitle(t('settings.webui.title.settings')); + setTitle(t('settings.webui.title.webui')); setAction(null); return () => { diff --git a/src/modules/tracker/screens/TrackingSettings.tsx b/src/modules/tracker/screens/TrackingSettings.tsx index 10c05d49..a5560e85 100644 --- a/src/modules/tracker/screens/TrackingSettings.tsx +++ b/src/modules/tracker/screens/TrackingSettings.tsx @@ -34,7 +34,7 @@ export const TrackingSettings = () => { const { setTitle } = useNavBarContext(); useLayoutEffect(() => { - setTitle(t('tracking.settings.title.settings')); + setTitle(t('tracking.title')); }, [t]); const {