From 3bab657c52ffec1e27170965b4ba777a23129349 Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Tue, 31 Dec 2024 13:19:58 +0100 Subject: [PATCH] Update "actualPages" immediately Instead of immediately updating the value once the page count changed, it got updated after "pagesToSpreadState" changed, which was after the rendering finished. This was the actual root cause of what was tried to be fixed with 9ab6ec89c7c0f7d346190a7ad6fd27efcd898ca1 --- src/modules/reader/components/viewer/ReaderViewer.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/reader/components/viewer/ReaderViewer.tsx b/src/modules/reader/components/viewer/ReaderViewer.tsx index f21354e3..972a1d47 100644 --- a/src/modules/reader/components/viewer/ReaderViewer.tsx +++ b/src/modules/reader/components/viewer/ReaderViewer.tsx @@ -139,7 +139,7 @@ const BaseReaderViewer = forwardRef( const imageRefs = useRef<(HTMLElement | null)[]>(pages.map(() => null)); const actualPages = useMemo(() => { - const arePagesLoaded = pageUrls.length; + const arePagesLoaded = !!totalPages; if (!arePagesLoaded) { return pages; } @@ -154,7 +154,7 @@ const BaseReaderViewer = forwardRef( } return pages; - }, [pagesToSpreadState, readingMode, shouldOffsetDoubleSpreads, readingDirection]); + }, [pagesToSpreadState, readingMode, shouldOffsetDoubleSpreads, readingDirection, totalPages]); const Pager = useMemo(() => getPagerForReadingMode(readingMode), [readingMode]); const inViewportType = READING_MODE_TO_IN_VIEWPORT_TYPE[readingMode];