From 3a976f8e1327b5415d6e0a17a6f086671482aa6d Mon Sep 17 00:00:00 2001
From: schroda <50052685+schroda@users.noreply.github.com>
Date: Fri, 22 May 2026 12:12:00 +0200
Subject: [PATCH] Fix updating migration search progress on manual match
 selection

The "success" and "completed" count could become larger than the "total" count when manually selecting a match for a successful search with no automatically selected match (e.g. when all matches are outdated)
---
 src/features/migration/MigrationEntries.ts |  4 ++++
 src/features/migration/MigrationManager.ts | 26 +++++++---------------
 2 files changed, 12 insertions(+), 18 deletions(-)

diff --git a/src/features/migration/MigrationEntries.ts b/src/features/migration/MigrationEntries.ts
index 30707e07..4bcf8e5d 100644
--- a/src/features/migration/MigrationEntries.ts
+++ b/src/features/migration/MigrationEntries.ts
@@ -10,6 +10,10 @@ import type { MigratableEntry, TMigrationEntry } from '@/features/migration/Migr
 import { MigrationEntryStatus } from '@/features/migration/Migration.types.ts';
 
 export class MigrationEntries {
+    public static isSearching(entry: TMigrationEntry): boolean {
+        return [MigrationEntryStatus.PENDING, MigrationEntryStatus.SEARCHING].includes(entry.status);
+    }
+
     public static getExcluded(entries: TMigrationEntry[]): TMigrationEntry[] {
         return entries.filter((entry) => entry.isExcluded);
     }
diff --git a/src/features/migration/MigrationManager.ts b/src/features/migration/MigrationManager.ts
index 9f4e688b..bf174655 100644
--- a/src/features/migration/MigrationManager.ts
+++ b/src/features/migration/MigrationManager.ts
@@ -589,18 +589,13 @@ export class MigrationManager {
         MigrationManager.updateState((draft) => {
             const entry = draft.entries[mangaId];
             if (entry) {
-                const isSearching = ![
-                    MigrationEntryStatus.SEARCH_FAILED,
-                    MigrationEntryStatus.SEARCH_COMPLETE,
-                ].includes(entry.status);
-                if (isSearching) {
+                if (MigrationEntries.isSearching(entry)) {
                     draft.searchProgress.completed += 1;
                     draft.searchProgress.success += 1;
                 }
 
                 entry.status = MigrationEntryStatus.SEARCH_COMPLETE;
                 entry.isManualSelection = true;
-
                 entry.selectedMatchMangaId = targetMangaId;
                 entry.selectedMatchSourceId = targetSourceId;
             }
@@ -623,15 +618,7 @@ export class MigrationManager {
                     draft.entries[mangaId].manualMatches = [...draft.entries[mangaId].manualMatches, match];
                 }
 
-                const isSearching = ![
-                    MigrationEntryStatus.SEARCH_FAILED,
-                    MigrationEntryStatus.SEARCH_COMPLETE,
-                ].includes(entry.status);
-
-                if (isSearching) {
-                    draft.searchProgress.completed += 1;
-                    draft.searchProgress.success += 1;
-                }
+                const isSearching = MigrationEntries.isSearching(entry);
 
                 entry.status = MigrationEntryStatus.SEARCH_COMPLETE;
                 entry.isManualSelection = true;
@@ -639,6 +626,8 @@ export class MigrationManager {
                 entry.selectedMatchSourceId = match.sourceId;
 
                 if (isSearching) {
+                    draft.searchProgress.completed += 1;
+                    draft.searchProgress.success += 1;
                     MigrationManager.searchAbortControllerByManga.get(mangaId)?.abort('Manual match selected');
                 }
             }
@@ -1003,6 +992,10 @@ export class MigrationManager {
             MigrationManager.updateState((draft) => {
                 const draftEntry = draft.entries[mangaId];
 
+                if (!MigrationEntries.isSearching(draftEntry)) {
+                    return;
+                }
+
                 if (draftEntry.searchMatches.length) {
                     if (draftEntry.selectedMatchMangaId != null) {
                         draftEntry.status = MigrationEntryStatus.SEARCH_COMPLETE;
@@ -1012,9 +1005,6 @@ export class MigrationManager {
                 } else {
                     draftEntry.status = MigrationEntryStatus.NO_MATCH;
                 }
-
-                draft.searchProgress.success += 1;
-                draft.searchProgress.completed += 1;
             });
         } catch (error) {
             if (mainSignal.aborted) {