From 38ac36d14cb84095c07b38a8315a265cf74fa8c9 Mon Sep 17 00:00:00 2001
From: schroda <50052685+schroda@users.noreply.github.com>
Date: Sat, 13 Sep 2025 14:13:32 +0200
Subject: [PATCH] Fix setting "default" download conversion mime type

The server expects the mime type to be "default", while the ui set it to "image/default"
---
 .../components/DownloadConversionSetting.tsx  | 28 +++++++++++++------
 1 file changed, 19 insertions(+), 9 deletions(-)

diff --git a/src/features/downloads/components/DownloadConversionSetting.tsx b/src/features/downloads/components/DownloadConversionSetting.tsx
index 42fec0d8..a44626f1 100644
--- a/src/features/downloads/components/DownloadConversionSetting.tsx
+++ b/src/features/downloads/components/DownloadConversionSetting.tsx
@@ -55,12 +55,20 @@ const normalizeConversions = (conversions: SettingsDownloadConversion[]): Settin
         target: normalizeMimeType(conversion.target),
     }));
 
+const toValidServerMimeType = (mimeType: string): string => {
+    if (isDefaultMimeType(mimeType)) {
+        return DEFAULT_MIME_TYPE;
+    }
+
+    return `${MIME_TYPE_PREFIX}${mimeType}`;
+};
+
 const toValidServerConversions = (conversions: SettingsDownloadConversion[]): SettingsDownloadConversion[] =>
     conversions
         .filter(({ mimeType, target }) => !!mimeType && !!target)
         .map((conversion) => ({
             ...conversion,
-            mimeType: `${MIME_TYPE_PREFIX}${conversion.mimeType}`,
+            mimeType: toValidServerMimeType(conversion.mimeType),
             target: `${MIME_TYPE_PREFIX}${conversion.target}`,
         }));
 
@@ -265,6 +273,15 @@ export const DownloadConversionSetting = ({
         onClose(conversions);
     };
 
+    const onSubmit = async () => {
+        try {
+            await updateSetting(toValidServerConversions(tmpConversions));
+            onClose(toValidServerConversions(tmpConversions));
+        } catch (e) {
+            // ignore error
+        }
+    };
+
     return (
         <>
             <ListItemButton disabled={false} onClick={() => setIsDialogOpen(true)}>
@@ -332,14 +349,7 @@ export const DownloadConversionSetting = ({
                         </Button>
                         <Stack direction="row">
                             <Button onClick={onCancel}>{t('global.button.cancel')}</Button>
-                            <Button
-                                disabled={hasInvalidConversion || !hasChanged}
-                                onClick={() =>
-                                    updateSetting(toValidServerConversions(tmpConversions)).then(() =>
-                                        onClose(toValidServerConversions(tmpConversions)),
-                                    )
-                                }
-                            >
+                            <Button disabled={hasInvalidConversion || !hasChanged} onClick={onSubmit}>
                                 {t('global.button.ok')}
                             </Button>
                         </Stack>