ChoChoX/suwayomi-material-you-webui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix collectable selection hook memoization

Browse Source
This commit is contained in:
schroda
2026-03-20 01:29:02 +01:00
parent 9aae34b8ad
commit 33c55f8b85
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/base/collection/hooks/useSelectableCollection.ts
View File

@@ -6,7 +6,7 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/. * file, You can obtain one at https://mozilla.org/MPL/2.0/.
*/ */
import { useCallback, useRef, useState } from 'react'; import { useCallback, useMemo, useRef, useState } from 'react';
export type SelectableCollectionReturnType<Id extends number | string, Key extends string = string> = { export type SelectableCollectionReturnType<Id extends number | string, Key extends string = string> = {
selectedItemIds: Id[]; selectedItemIds: Id[];
@@ -41,11 +41,17 @@ export const useSelectableCollection = <Id extends number | string, Key extends
const lastSelectedItemInfoRef = useRef<{ id: Id; key: Key }>(undefined); const lastSelectedItemInfoRef = useRef<{ id: Id; key: Key }>(undefined);
const selectedItemIds = [...new Set(Object.values(keyToSelectedItemIds).flat())]; const selectedItemIds = useMemo(
() => [...new Set(Object.values(keyToSelectedItemIds).flat())],
[keyToSelectedItemIds],
);
const areAllItemsSelected = selectedItemIds.length === totalCount; const areAllItemsSelected = selectedItemIds.length === totalCount;
const areNoItemsSelected = !selectedItemIds.length; const areNoItemsSelected = !selectedItemIds.length;
const keySelectedItemIds = keyToSelectedItemIds[currentKey] ?? []; const keySelectedItemIds = useMemo(
() => keyToSelectedItemIds[currentKey] ?? [],
[keyToSelectedItemIds, currentKey],
);
const areAllItemsForKeySelected = keySelectedItemIds.length === keyCount; const areAllItemsForKeySelected = keySelectedItemIds.length === keyCount;
const areNoItemsForKeySelected = keySelectedItemIds.length === 0; const areNoItemsForKeySelected = keySelectedItemIds.length === 0;