From 33910cc89da3674731bb91821f1873dc862502b6 Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Fri, 13 Dec 2024 02:32:36 +0100 Subject: [PATCH] Prevent opening previous/next chapter on page selection In case the first/last page was opened and a specific page was selected, instead of opening the page, the previous/next chapter was opened due to incorrectly handling the page change as a previous/next page change --- src/modules/reader/services/ReaderControls.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/modules/reader/services/ReaderControls.ts b/src/modules/reader/services/ReaderControls.ts index 9e648cc6..e8846974 100644 --- a/src/modules/reader/services/ReaderControls.ts +++ b/src/modules/reader/services/ReaderControls.ts @@ -278,6 +278,14 @@ export class ReaderControls { setIsOverlayVisible(false); } + const hideTransitionPage = () => setTransitionPageMode(ReaderTransitionPageMode.NONE); + + if (typeof page === 'number') { + setPageToScrollToIndex(page); + hideTransitionPage(); + return; + } + const shouldOpenPreviousChapter = isFirstPage && isATransitionPageVisible && convertedPage === 'previous' && !!previousChapter; if (shouldOpenPreviousChapter) { @@ -292,14 +300,6 @@ export class ReaderControls { return; } - const hideTransitionPage = () => setTransitionPageMode(ReaderTransitionPageMode.NONE); - - if (typeof page === 'number') { - setPageToScrollToIndex(page); - hideTransitionPage(); - return; - } - const needToHideTransitionPage = isATransitionPageVisible && !isContinuousReadingModeActive; switch (convertedPage) { case 'previous':