From 32fb7b0909e16a1e959646d34452c549bfefe49d Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Sun, 15 Mar 2026 14:42:49 +0100 Subject: [PATCH] Fix deleting global reader settings It replaced the global settings with the manga specific ones. Regression 63ebfd120e5760e4e86141716d2f98d2d572069d --- src/features/reader/services/ReaderService.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/features/reader/services/ReaderService.ts b/src/features/reader/services/ReaderService.ts index be135511..09fad25e 100644 --- a/src/features/reader/services/ReaderService.ts +++ b/src/features/reader/services/ReaderService.ts @@ -399,16 +399,17 @@ export class ReaderService { isGlobal: boolean = false, profile?: ReadingMode, ): void { + const isGlobalSetting = isGlobal || GLOBAL_READER_SETTING_KEYS.includes(setting); + const metaHolderType = isGlobalSetting ? 'global' : 'manga'; + const { manga: currentManga } = getReaderStore(); - const manga = isGlobal ? GLOBAL_READER_SETTINGS_MANGA : (currentManga ?? FALLBACK_MANGA); + const manga = isGlobalSetting ? GLOBAL_READER_SETTINGS_MANGA : (currentManga ?? FALLBACK_MANGA); if (!manga || manga.id === FALLBACK_MANGA.id) { return; } const key = getMetadataKey(setting, profile !== undefined ? [profile?.toString()] : undefined); - const isGlobalSetting = isGlobal || GLOBAL_READER_SETTING_KEYS.includes(setting); - const metaHolderType = isGlobalSetting ? 'global' : 'manga'; const existingMeta = this.getMetadataWithUnmodifiedKey(manga, metaHolderType, key, isGlobalSetting);