update react scripts dependency (#255)

* Move "dependencies" close to "devDependencies"

Makes it easier to have a quick overview

* Upgrade "react-scripts" to latest version

With new versions of node (> v16) the build scripts fails with the following error "error:0308010C:digital envelope routines::unsupported"

* Upgrade "react-scripts" to v5 - Fix import

* Upgrade "eslint" dependencies

The latest version of "react-scripts" uses eslint v8 causing the following error "... ERROR in Plugin "react" was conflicted between ".eslintrc.js" >> eslint-config-airbnb ..."

* Upgrade "eslint" dependencies - Allow nested components as props

* Upgrade "eslint" dependencies - Fix lint issues

src/components/util/AppbarSearch.tsx

@@ -66,26 +66,26 @@ const AppbarSearch: React.FunctionComponent<IProps> = (props) => {
         };
     }, [handleSearchShortcut]);
 
+    if (searchOpen) {
+        return (
+            <Input
+                value={query || ''}
+                onChange={handleChange}
+                onBlur={handleBlur}
+                inputRef={inputRef}
+                endAdornment={
+                    <IconButton onClick={cancelSearch}>
+                        <CancelIcon />
+                    </IconButton>
+                }
+            />
+        );
+    }
+
     return (
-        <>
-            {searchOpen ? (
-                <Input
-                    value={query || ''}
-                    onChange={handleChange}
-                    onBlur={handleBlur}
-                    inputRef={inputRef}
-                    endAdornment={
-                        <IconButton onClick={cancelSearch}>
-                            <CancelIcon />
-                        </IconButton>
-                    }
-                />
-            ) : (
-                <IconButton onClick={openSearch}>
-                    <SearchIcon />
-                </IconButton>
-            )}
-        </>
+        <IconButton onClick={openSearch}>
+            <SearchIcon />
+        </IconButton>
     );
 };
 

src/components/util/LoadingPlaceholder.tsx

@@ -30,7 +30,7 @@ export default function LoadingPlaceholder(props: IProps) {
         }
 
         if (children) {
-            return <>{children}</>;
+            return children as JSX.Element;
         }
     }