From 14a881f17f1396a27d425347a6adea0900ce9d5d Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Mon, 22 Dec 2025 12:56:18 +0100 Subject: [PATCH] Consider "empty" download conversion as unchanged --- .../downloads/components/DownloadConversionSetting.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/features/downloads/components/DownloadConversionSetting.tsx b/src/features/downloads/components/DownloadConversionSetting.tsx index 1d00b98c..93029797 100644 --- a/src/features/downloads/components/DownloadConversionSetting.tsx +++ b/src/features/downloads/components/DownloadConversionSetting.tsx @@ -39,10 +39,14 @@ const isValidCompressionLevel = (compression: number | null | undefined): boolea compression == null || (compression >= DOWNLOAD_CONVERSION_COMPRESSION.min && compression <= DOWNLOAD_CONVERSION_COMPRESSION.max); +const isUnsetConversion = (mimeType: string, target: string): boolean => mimeType === '' && target === ''; + const containsInvalidConversion = (conversions: SettingsDownloadConversion[]): boolean => conversions.some( - ({ mimeType, compressionLevel }, index) => - !isValidCompressionLevel(compressionLevel) || isDuplicateConversion(mimeType, index, conversions), + ({ mimeType, compressionLevel, target }, index) => + isUnsetConversion(mimeType, target) || + !isValidCompressionLevel(compressionLevel) || + isDuplicateConversion(mimeType, index, conversions), ); const normalizeConversions = (conversions: SettingsDownloadConversion[]): SettingsDownloadConversion[] =>