From 050fbc794c18a430c3cb860993ae511703af9896 Mon Sep 17 00:00:00 2001 From: schroda <50052685+schroda@users.noreply.github.com> Date: Thu, 24 Oct 2024 17:30:24 +0200 Subject: [PATCH] Properly reset "app bar height" --- .../navigation-bar/components/DefaultNavBar.tsx | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/modules/navigation-bar/components/DefaultNavBar.tsx b/src/modules/navigation-bar/components/DefaultNavBar.tsx index 81ff54b5..39c3914d 100644 --- a/src/modules/navigation-bar/components/DefaultNavBar.tsx +++ b/src/modules/navigation-bar/components/DefaultNavBar.tsx @@ -6,7 +6,7 @@ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ -import { useCallback, useContext, useEffect, useLayoutEffect, useMemo, useRef } from 'react'; +import { useCallback, useContext, useLayoutEffect, useMemo, useRef } from 'react'; import AppBar from '@mui/material/AppBar'; import Toolbar from '@mui/material/Toolbar'; import Typography from '@mui/material/Typography'; @@ -92,7 +92,13 @@ export function DefaultNavBar() { appBarRef, useCallback(() => setAppBarHeight(appBarRef.current?.clientHeight ?? 0), [appBarRef.current]), ); - useEffect(() => setAppBarHeight(0), []); + useLayoutEffect(() => { + if (!override.status) { + setAppBarHeight(0); + } + + return () => setAppBarHeight(0); + }, [override.status]); const activeNavBar: NavbarItem['show'] = isMobileWidth ? 'mobile' : 'desktop'; const visibleNavBarItems = useMemo(