Fix open track settings on library manga track action

Was never properly implemented, thus, didn't work at all and instead only an empty dialog was shown
This commit is contained in:
schroda
2024-09-14 01:37:36 +02:00
parent fe6757f308
commit 009da03236

View File

@@ -59,6 +59,15 @@ export const TrackManga = ({ manga }: { manga: MangaIdInfo & Pick<MangaType, 'ti
const isSearchActive = searchModeForTracker !== undefined;
const OptionalDialogContent = useMemo(() => (isSearchActive ? Box : DialogContent), [isSearchActive]);
const loading = trackerList.loading || mangaTrackRecordsList.loading;
const error = trackerList.error ?? mangaTrackRecordsList.error;
useEffect(() => {
if (!loading && !error && !trackersInUse.length && !loggedInTrackers.length) {
navigate('/settings/trackingSettings');
}
}, [loading]);
useEffect(() => {
Promise.all(
mangaTrackRecords.map((trackRecord) => requestManager.fetchTrackBind(trackRecord.id).response),
@@ -90,7 +99,6 @@ export const TrackManga = ({ manga }: { manga: MangaIdInfo & Pick<MangaType, 'ti
[trackersInUseIds, searchModeForTracker, mangaTrackRecords],
);
const error = trackerList.error ?? mangaTrackRecordsList.error;
if (error) {
return (
<EmptyViewAbsoluteCentered
@@ -111,15 +119,10 @@ export const TrackManga = ({ manga }: { manga: MangaIdInfo & Pick<MangaType, 'ti
);
}
const loading = trackerList.loading || mangaTrackRecordsList.loading;
if (loading) {
return <LoadingPlaceholder />;
}
if (!loggedInTrackers) {
navigate('/settings/trackingSettings');
}
if (!isSearchActive) {
return (
<OptionalDialogContent